Repository navigation
Remove sunset BOM versions and update support link in README - #926
pattersonlois wants to merge 2 commits into
Conversation
- Remove sunset v21 and v22 stub references and duplicate v24 entry in google-ads-bom/build.gradle. - Replace the sunset Google Ads API forum link in README.md with the Google Ads API support page.
| api "com.google.api-ads:google-ads-stubs-v22:${version}" | ||
| api "com.google.api-ads:google-ads-stubs-v23:${version}" | ||
| api "com.google.api-ads:google-ads-stubs-v24:${version}" | ||
| rootProject.subprojects |
There was a problem hiding this comment.
I'd prefer we keep this as-is. Each version addition or subtraction is a one-time event, so I'd rather just keep this as a static list, same as the root settings.gradle. If we instead go with this change, the dependency list becomes dynamic, which could lead to other problems.
If we're missing duplicates and sunset versions during code reviews, I'd prefer we just make a point of reminding reviewers to pay closer attention to this file.
There was a problem hiding this comment.
I had cl/1015794471 for the second part with primordial, but I reverted it.
There was a problem hiding this comment.
dependencies {
// This makes this BOM inherit all dependency versions from the Google Cloud
// BOM. This version is determined based on the current used version of
// google-cloud-shared-dependencies.
api(platform("com.google.cloud:libraries-bom:26.81.0"))
// Add constraints for all of this project's artifacts.
constraints {
rootProject.subprojects
.findAll { it.name.startsWith("google-ads-stubs-v") }
.each { api it }
api project(":google-ads")
api project(":google-ads-codegen")
api "com.google.api-ads:google-ads-shadowjar:${version}"
}
}
There was a problem hiding this comment.
google-ads-stubs-v*constraints dynamically fromrootProject.subprojectsingoogle-ads-bom/build.gradle(matchinggoogle-ads-codegen/build.gradle) and use project references for:google-adsand:google-ads-codegen, eliminating sunsetv21/v22stub references and duplicatev24entries without manual upkeep on version additions or removals.### Support forumlink with### Support(https://developers.google.com/google-ads/api/support) inREADME.md.