Repository navigation
fix(bigquery): Recover query jobs after ambiguous retries - #36735
Open
divenyijanos wants to merge 1 commit into
Open
divenyijanos wants to merge 1 commit into
divenyijanos wants to merge 1 commit into
Conversation
- Retrieve an existing query job when a retry receives a duplicate response - Preserve AlreadyExistsError for duplicate responses on the initial insertion attempt - Add regression coverage for both retry recovery and genuine initial collisions Fixes googleapis#36734
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover an existing BigQuery query job when a retry receives
409 duplicate. An initial duplicate still raisesGoogle::Cloud::AlreadyExistsError, preserving genuine job ID collision behavior.Fixes #36734.
Evidence
project_query_job_test.rbraisedGoogle::Cloud::AlreadyExistsErrorfor a retryablebackendErrorfollowed by409 duplicate.rake testreaches 1,435 runs and fails on 24 sparse-checkout fixture errors; focused affected tests pass. Most errors are missingacceptance/datafixtures. Three existing local-load mocks also reject keyword arguments under this dependency/runtime combination.Merge Danger
Door: Two-way
The change is isolated to query-job insertion recovery and can be reverted without data migration or public interface changes.
Blast Radius: Query jobs
Only duplicate responses after this invocation has already retried are recovered. Initial duplicate responses continue to raise.