Repository navigation
fix(mf4): defer asammdf imports until reader/writer construction - #2123
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
Open
timothyanderson096-ocdealcheck wants to merge 1 commit into
timothyanderson096-ocdealcheck wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Importing
asammdffirst can re-entercanthroughcanmatrix/canopenbeforeasammdfis initialized. The optional-import guard then permanently treats an installed dependency as missing.asammdfwhen an MF4 reader or writer is constructed.asammdfitself is absent; preserve the original error for missing transitive dependencies.asammdfloader. The deterministic case does not requirecanopenin upstream test dependencies.Related Issues / Pull Requests
Closes #2122. Thanks to @nehalkpatel for the reproduction and dependency-chain analysis.
Existing packed-error-frame PR #2115 is separate and is not included or stacked here.
Type of Change
Checklist
tox).Validation and limits
Tested on Linux / CPython 3.12.14 with asammdf 8.7.2, canmatrix 1.2 and canopen 2.4.1. Published commit
2c0bb48693d1e96332ef8cb9df74bc9e363e41edhas the exact tested complete treede8a6291bdd23d56b96df7ffe9baefd09a9a52f3, based on unchanged upstreamb4f82abede25ff83376be793a2935c41f81c3869.No hosted CI, hardware, other OS/interpreter execution, minimum asammdf 6 validation, full tox/docs run or whole-project Pylint result is claimed. Black emits an inferred Python 3.15 target warning under this Python 3.12 runtime; explicit Python 3.10 changed-file checks also pass.
Prepared with OpenAI Codex assistance. Maintainer review remains requested.
Timothy Anderson — Spotted Ridge Engineering / OC Labs · Independent software verification · GDN (Global Decision Network)
timothyanderson096@gmail.com · Engineering evidence