Repository navigation
fix(chart): retain diagnostics when cleanup is skipped - #883
Merged
cpanato merged 1 commit intoNov 10, 2026
Merged
Conversation
Print events, pod details and container logs before optional teardown in install and upgrade tests. Keep resources intact with --skip-clean-up while retaining diagnostics on successful and failed runs. Fixes helm#880 Signed-off-by: Виктор Быстров <anatema@bk.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
--skip-clean-upcurrently suppresses events, pod descriptions and logs because diagnostics run only inside the teardown callback. Always collect diagnostics when an install or upgrade attempt finishes, then perform teardown only when cleanup is enabled. Diagnostics still run before release or namespace deletion.Which issue this PR fixes: Fixes #880.
Special notes for your reviewer:
The regression test covers install and upgrade success/failure, failed test hooks, skipped previous revisions, custom/generated namespaces, and both cleanup modes. It asserts the complete operation order, namespace and pod selector. The 12 skip-cleanup cases fail on unmodified main; all 24 cases pass with this fix.
Validation with Go 1.27.3 and golangci-lint 2.14.0:
All passed. Kubernetes and Helm operations are faked; no live-cluster tests were run.