Repository navigation
fix(chart): continue diagnostics after individual failures - #884
Merged
cpanato merged 1 commit intoNov 10, 2026
Merged
Conversation
Collect the remaining pod and container diagnostics after a failed request, and close GitHub output groups even when a log command fails. Avoid querying containers when log output is disabled. Signed-off-by: Виктор Быстров <anatema@bk.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
A failed container-list or log request currently stops collection of otherwise available diagnostics. With
--github-groups, a failed print command also returns before emitting the matching group end marker, so later CI output can be folded into the wrong group.Continue collecting remaining pods and containers after individual failures, retain the printed error, and always finish each output group. When
--print-logsis disabled, do not query container lists before describing the remaining pods.Special notes for your reviewer:
The regression suite covers event failures, init/regular container discovery failures, individual log failures, disabled logs and successful runs, with GitHub grouping both on and off. It checks the collected operations, error output and balanced group markers. These failure paths reproduce on unmodified main.
Validation with Go 1.27.3 and golangci-lint 2.14.0:
All passed. Tests use a fake kubectl client; no live-cluster tests were run.