Repository navigation
feat: support glob patterns for action distribution outputs - #657
Conversation
|
Internal - Pull request - Continuous Integration - Test results Workflow run and full reports · Commit e95fd24 Jobs: 6 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned. Test: 298 passed · 0 failed · 0 skipped. Test detailsTest resultsTest Results
Job results and report availability
Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs. |
|
Internal - Pull request - Continuous Integration - Code coverage Workflow run and full reports · Commit e95fd24 Jobs: 6 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned. Coverage: 5 source report(s); percentages remain separate. Coverage detailsCoverage resultsci-reports-1-test-action-distributions-actions-action-distributions-d0a98db1-ad6b-4517-8f31-802c90c6893f/lcov.infoCoverage
Overall: 97.93% 🟢 ci-reports-1-test-action-lint-pull-request-title-actions-quality-lint-pull-request-title-e8b46e62-c32b-498e-8b83-fc943d7a1661/lcov.infoCoverage
Overall: 100.00% 🟢 ci-reports-1-test-action-need-fix-to-issue-actions-need-fix-to-issue-45e213e4-b8ef-4821-8658-ea26aaec6a13/lcov.infoCoverage
Overall: 100.00% 🟢 ci-reports-1-test-action-parse-ci-reports-actions-quality-parse-ci-reports-e0515079-67aa-4c24-8d04-3b5b8433531e/lcov.infoCoverage
Overall: 95.39% 🟢 ci-reports-1-test-action-test-action-distribution-actions-quality-test-action-distribution-8aceb3f0-7531-4b19-9111-3270cda6884a/lcov.infoCoverage
Overall: 100.00% 🟢 Job results and report availability
Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs. |
|
Internal - Pull request - Continuous Integration - Lint results Workflow run and full reports · Commit e95fd24 Jobs: 6 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned. Lint: Collected diagnostics and Super-Linter summaries. Execution status is included in the job outcomes. Super-Linter detailsSuper-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter Job results and report availability
Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs. |
Workspace consumers currently repeat every generated bundle directory in both distribution callers. Support
output-directory: actions/**/distso one pattern covers their committed action bundles. Literal paths remain supported; patterns accept*,**and?, relative to each selected package.Both the builder and writer resolve patterns from directory entries in the trusted PR base tree. The resulting literal allowlist governs change selection, artifact collection, required files, publication and stale-file deletion. Matching directories introduced only by the PR cannot expand the writer's scope. Unmatched patterns, truncated trees, selected symlinks/submodules and duplicate or overlapping output directories fail validation; hidden and
node_modulespaths are excluded.DistributionOutputsowns resolution and containment. Existing package discovery, author/origin validation and atomic commit publication retain their responsibilities. Package discovery also excludes generated manifests selected by output patterns. No dependency or runtime upgrade is required.Validation:
packageinvocation, and validates an 87.4 MiB artifact.actions/**/dist.make lint, complete source-snapshot Docker lint andgit diff --checkpass. The distribution is rebuilt with the pinned ncc and checked for reproducibility after committing.Metadata, the development guide and ADR 0002 document the pattern contract. Generated action/workflow references remain owned by the existing release documentation job.
Consumer adoption is tracked in cloud-native-aixmarseille/meetup-event-automation#883. It must use a release containing this feature before merging; a tested implementation SHA can be used for draft validation.