Repository navigation
Add !Send server example - #115
Merged
Merged
Conversation
|
Is there a reason this was closed without merging? |
Contributor
Author
|
I don't remember a good reason. I've re-opened, and resolved the merge conflict for @seanmonstar to take a look and accept it, if deemed useful. |
cratelyn
added
S-waiting-on-review
cratelyn
self-requested a review
September 24, 2026 18:50
`cargo check --features=full --examples` returns a number of warnings. this commit fixes these warnings. Signed-off-by: katelyn martin <git@katelyn.world>
this macro allows callers to specify the kind of runtime they wish to use. we can use this, instead of laying out the boilerplate to do this by hand, to provide a more concise example. Signed-off-by: katelyn martin <git@katelyn.world>
this type isn't used in the example. we can remove it. Signed-off-by: katelyn martin <git@katelyn.world>
in hyperium#330, we introduced a new executor that can spawn futures onto a local runtime. this commit replaces the `LocalExec` type in the example with this executor, to further distill this example. Signed-off-by: katelyn martin <git@katelyn.world>
Signed-off-by: katelyn martin <git@katelyn.world>
cratelyn
approved these changes
Nov 5, 2026
cratelyn
left a comment
cratelyn
left a comment
Member
There was a problem hiding this comment.
thanks for opening this, and thank you for your patience, @JanBerktold! i pushed some additional changes to golf this down a bit further. i introduced a local executor in #330, so this example uses that executor instead now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't realize the auto connection was ready to be used with a
!Sendexecutor, so I went down a long rabbit hole. This adds an example hopefully short-circuiting this process for future users.