Repository navigation
fix(client): respect local address family when happy eyeballs is disabled - #346
Open
akasakariko wants to merge 1 commit into
Open
akasakariko wants to merge 1 commit into
akasakariko wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes hyperium/hyper#4258
HttpConnector::set_local_addressdocuments that all sockets are bound to the configured address, but withset_happy_eyeballs_timeout(None)remote addresses of the other IP version were still attempted.ConnectingTcp::newonly filtered addresses throughsplit_by_preferencewhen happy eyeballs was enabled, sobind_local_addresssilently skipped the bind for a mismatched family and the connection went out unboundThis applies the same family filter when happy eyeballs is disabled, dropping remote addresses that cannot be reached from the configured local address
Reproduction: with a connector bound to
::1and happy eyeballs disabled, connecting to127.0.0.1succeeded before this change and now fails without attempting the incompatible addressVerification
cargo test --all-features: all tests pass, including the new regression testcargo fmt --all --check: cleanThe new regression test fails on master and passes with this change
The description, docs, and comments (words meant for humans) are written by a human, not by an LLM.