Repository navigation
feat: port the ISC grammar to the parsanol .parg portable DSL (WO13) - #829
Merged
Merged
Conversation
grammar/isc.parg mirrors lib/interscript/isc/grammar/concerns/*.rb rule-for-rule: system/metadata/notes/relations/tests/aliases/ dependencies/stages, both sub forms, before/after/not_* constraints, any(range/set/alias/item), capture/maybe/some, ref(N), the strict comment_item, and the corpus escape rulings (\uXXXX, \U 4..8, lone \U). Root pins full-input consumption with an explicit !utf.
tools/isc-parg-check compiles the .parg through parsanol-rs (parse_grammar_with_mode + compile_entry_mode, edition v1) and parses corpus files with the portable engine, reporting failure wires (offset/line/col/expected) on misses. --expect-reject runs the negative corpus: truncated rule string, unbalanced brace, stray stage identifier (strict parse), trailing garbage. Verdicts are at parity with the Ruby DSL on all runs: 319/319 corpus files parse (318 maps/ + 1 maps-staging/), 4/4 negatives and 7/7 construct-coverage fixtures (stage(name) paren form, sequence, title_case kwargs, separate separator, kwarg funcall, run map.N.stage.M, relations, specification/provenance comma lists, aliases, capture+ref, CJK/emoji string content) match DSL accept/reject exactly.
No concern construct proved inexpressible. The file records the one forced deviation (keyword alternation reordered longest-first for the parg shadow lint — semantics-preserving under negative lookahead), the omitted dead concern rules (authority/source_spelling/target_spelling/ identifying/name fields are unreachable from metadata_field), the field_value repeat-binding trap the corpus caught (din-hye), and the any-matches-newlines semantics multiline descriptions depend on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan