Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traceback.from_string()accepts file locations without a function name, including the compiler location in standardSyntaxErroroutput. Callingas_traceback()on that parsed traceback currently raisesTypeError: replace() argument 'co_name' must be str, not None.Keep the compiled stub's native name when the parsed name is missing. Supplied names and serialized frame data stay unchanged. The regression uses a real formatted
SyntaxErrorand fails on the original code. The compiler location remains the synthetic frame already accepted by the parser; this does not provide an exactSyntaxErrorformatting round trip.Validation on macOS arm64:
twine checkandcheck-manifestpassed. The configured Ruff lint/format, Taplo formatting, whitespace, final-newline, mixed-line-ending and debug-statement hooks passed. Separate Taplo syntax-only lint (--no-schema) passed.autoapi/indexwarning. Link checking failed on the unchanged Coveralls URL (403); the added author link passed.The full tox matrix was not run.
tox -e checkreached a local 55-second deadline during dependency installation; after installing the declared dependencies with uv, the package checks and remaining hooks were run individually as described above. The combined pre-commit run also reached that deadline during Taplo's online schema lint. Online schema validation remains unverified.AI assistance: OpenAI Codex helped investigate, implement, test, and review this change.