Repository navigation
Conversation
Since 4.5.0 the numberFormat helper upper-cased the format argument before using it as a DecimalFormat pattern, so literal text changed case: "#,##0.00 'items'" rendered "3.14 ITEMS". Upper-case only the copy used to look up the integer/percent/currency/default styles, and pass the original string to DecimalFormat as before 4.5.0. The style lookup and the roundingMode lookup now use Locale.ROOT, so "integer" and roundingMode="ceiling" keep working when the default locale is Turkish. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 4.5.0 (#1161),
numberFormatupper-cases the format argument before it passes the argument toDecimalFormat. As a result, literal text in a pattern changes case:3.14 items3.14 ITEMSWith this PR, only the lookup of the
integer/percent/currencystyles uses the upper-cased copy.DecimalFormatgets the pattern as written, as it did in 4.4.0.The style lookup and the
roundingModelookup also useLocale.ROOTnow. With a Turkish default locale, two things went wrong:"integer"became"İNTEGER". It no longer matched a style, so it was used as a pattern and renderedİNTEGER3.roundingMode="ceiling"failed withNo enum constant java.math.RoundingMode.CEİLİNG.Tests:
NumberFormatTest.patternWithLiteralTextandNumberFormatTest.namesDoNotDependOnDefaultLocalefail on master and pass with this change.mvn -pl handlebars testpasses: 1064 tests, with the same 3 skipped as before.spotless:checkis clean.