Repository navigation
Conversation
justdan6
marked this pull request as ready for review
November 4, 2026 04:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The development environment now builds from a tracked Dockerfile instead of depending on an image whose build recipe was ignored. It installs Composer 2.11.1 with checksum verification, refreshes available Ubuntu packages, locks the latest published compatible Hack libraries, initializes HTTP autoloading, and supplies the sample test's missing square_vec function. Compose builds locally, fails startup when dependencies fail, runs as a non-root user, and checks HTTP health.
HHVM's public binary distribution remains at 4.172.1, requiring Ubuntu 20.04/PHP 7.4. The README documents the newer source-only 4.172.3 tag and unsupported runtime stack rather than claiming those components are current. The latest HHAST release rejects HHVM 4.172's AST schema, so it is replaced with the native Hack linter; its JSON diagnostics are checked because hh_client exits zero even with lint errors. HHVM_DISABLE_PERSONALITY allows the typechecker to run under Docker's default seccomp profile.
Validation: clean Docker build, Composer install/validation/platform checks, 2 passing unit tests, native lint, typecheck, and the Hello World HTTP smoke test pass on native x86-64 Linux in GitHub Actions. A negative fixture also confirms lint fails on diagnostics from an otherwise successful hh_client process. Local Apple Silicon CLI checks pass, while HTTP under Docker Desktop translation fails; Apple Silicon instructions therefore require a full Colima/QEMU x86-64 VM. That full VM path has not been revalidated here.
The README includes rebuild/recreate commands, dependency updates, host tooling setup, and manual Docker Hub publishing. The registry image is not published automatically.