Repository navigation
Conversation
knative-prow
Bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
size/XL
knative-prow
Bot
added
size/XXL
knative-prow
Bot
added
size/XL
knative-prow
Bot
added
size/XXL
knative-prow
Bot
added
size/XL
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add nine self-contained
ci.shsmoke-test scripts for existing samples that currently have none:Each script follows the existing
main→build→deploy→testpattern. Fixtures and client checks are contained in the relevant scripts. GitHub API calls use a local fixture and need no real credentials.Existing
ci.shscripts and.github/workflows/samples-test.yamlare unchanged. No new application samples, support libraries, or harness regression tests are added.Bookstore samples are deliberately excluded for now; there are no bookstore changes in this PR. Dependabot configuration changes are also excluded.
Validation
Local runtime testing was stopped at the author's request; GitHub CI will validate the final version. The dedicated local test cluster has been deleted.