Skip to content

fix: resolve ws 8.22.0 to 8.23.0 - #1132

Merged
andy-knock merged 1 commit into
mainfrom
cjbell-vulnerable-javascript-dependencies-69fa
Nov 18, 2026
Merged

andy-knock merged 1 commit into
mainfrom
cjbell-vulnerable-javascript-dependencies-69fa

Conversation

@cursor

@cursor cursor Bot commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Description

Resolves the open ws finding from the 2026-11-17 Vanta scan of the javascript repository. @expo/cli@58.1.20 requests ws@^8.12.1. That range now resolves to 8.23.0, which is inside the range Expo already allows.

A local smoke check loaded ws from @expo/cli, confirmed version 8.23.0, opened a server with maxPendingAutoPongs, and round-tripped one message.

ws 8.22.0, now 8.23.0

KNO-16910

  • AIKIDO-2026-844803 (low). A peer can exhaust memory by flooding Ping frames while reads are paused, so automatic Pong responses accumulate. Affected through 8.22.2. Fixed in 8.23.0. Remediate by 2027-01-01.

Reported, left in place

  • minimatch@10.2.6, CVE-2026-118764 (high). KNO-16440. The only parent is @expo/fingerprint@0.21.10, which requests ^10.2.6 and matches with { dot: true }. There is no patched 10.x release. 11.0.9 is the latest, and minimatch 11 changes globstar and extglob matching, which changes fingerprint hashes. Expo declined that upgrade in chore(fingerprint): Drop glob and add minimatch@^10 usage note expo/expo#53091. The advisory's amplification runs when optimizationLevel is 2 or higher, and fingerprint leaves the default at 1.
  • yargs@17.7.2, AIKIDO-2026-922647 (low). KNO-16335. The fix is in 18.1.0. 17.7.3 does not include it, and its apply-extends.js is byte-identical to 17.7.2. Today's React Native nightly, react-native@0.89.0-rc.1, Metro 0.88.0, and @react-native/codegen still request yargs@^17.6.2. Yargs 18 is ESM-only, and Metro's CLI still calls require("yargs").

ws@6.2.3 and ws@7.5.10 are still installed and were not reported.

Todos

None.

Checklist

  • Tests have been added for new features or major refactors to existing features.

Screenshots or videos

Not applicable.

Open in Web View Automation 

@expo/cli requests ws ^8.12.1. Vanta reports AIKIDO-2026-844803 on 8.22.0, and 8.23.0 is the patched release inside that range.

Co-authored-by: chris <chris@knock.app>
@cursor
cursor Bot requested a review from a team as a code owner November 17, 2026 12:11
@cursor
cursor Bot requested review from kylemcd and thomaswhyyou and removed request for a team November 17, 2026 12:11
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
javascript-ms-teams-connect-example Ready Ready Preview Nov 17, 2026 12:14pm UTC
javascript-nextjs-example Ready Ready Preview Nov 17, 2026 12:14pm UTC
javascript-slack-connect-example Ready Ready Preview Nov 17, 2026 12:14pm UTC
javascript-slack-kit-example Ready Ready Preview Nov 17, 2026 12:14pm UTC

Request Review

@linear-code

linear-code Bot commented Nov 17, 2026

Copy link
Copy Markdown

KNO-16910

@changeset-bot

changeset-bot Bot commented Nov 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c727e4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@knocklabs/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.63%. Comparing base (81b9db8) to head (c727e4b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1132   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files         142      142           
  Lines        4540     4540           
  Branches     1319     1319           
=======================================
  Hits         3570     3570           
  Misses        873      873           
  Partials       97       97           

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the dependency-update approval path (Yarn pin of ws to 8.23.0 with lockfile and changeset) and CI is green, but GitHub rejected an approval because this automation cannot approve its own PR. Human review is needed to merge, and no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: SDK approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch pin of ws 8.22.0 to 8.23.0 meets the dependency-update bar (CI green, Bugbot clean), but GitHub rejected an approval because this automation cannot approve its own PR. Human review is needed to merge, and no reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Depdency updates (control, switchboard, CLI, javascript, telegraph)

@andy-knock
andy-knock merged commit 7089685 into main Nov 18, 2026
16 checks passed
@andy-knock
andy-knock deleted the cjbell-vulnerable-javascript-dependencies-69fa branch November 18, 2026 15:03

This branch was successfully deployed

4 active deployments
Preview – javascript-nextjs-example — c727e4b5 Deployed Nov 17, 2026 by vercel[bot]
Preview – javascript-ms-teams-connect-example — c727e4b5 Deployed Nov 17, 2026 by vercel[bot]
Preview – javascript-slack-connect-example — c727e4b5 Deployed Nov 17, 2026 by vercel[bot]
Preview – javascript-slack-kit-example — c727e4b5 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants