Repository navigation
fix: resolve ws 8.22.0 to 8.23.0 - #1132
Conversation
@expo/cli requests ws ^8.12.1. Vanta reports AIKIDO-2026-844803 on 8.22.0, and 8.23.0 is the patched release inside that range. Co-authored-by: chris <chris@knock.app>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: c727e4b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1132 +/- ##
=======================================
Coverage 78.63% 78.63%
=======================================
Files 142 142
Lines 4540 4540
Branches 1319 1319
=======================================
Hits 3570 3570
Misses 873 873
Partials 97 97 |
There was a problem hiding this comment.
This matches the dependency-update approval path (Yarn pin of ws to 8.23.0 with lockfile and changeset) and CI is green, but GitHub rejected an approval because this automation cannot approve its own PR. Human review is needed to merge, and no reviewers were assigned.
Sent by Cursor Approval Agent: SDK approver
There was a problem hiding this comment.
This patch pin of ws 8.22.0 to 8.23.0 meets the dependency-update bar (CI green, Bugbot clean), but GitHub rejected an approval because this automation cannot approve its own PR. Human review is needed to merge, and no reviewers were assigned.
Sent by Cursor Approval Agent: Depdency updates (control, switchboard, CLI, javascript, telegraph)


Description
Resolves the open
wsfinding from the 2026-11-17 Vanta scan of the javascript repository.@expo/cli@58.1.20requestsws@^8.12.1. That range now resolves to 8.23.0, which is inside the range Expo already allows.A local smoke check loaded
wsfrom@expo/cli, confirmed version 8.23.0, opened a server withmaxPendingAutoPongs, and round-tripped one message.ws 8.22.0, now 8.23.0
KNO-16910
Reported, left in place
minimatch@10.2.6, CVE-2026-118764 (high). KNO-16440. The only parent is@expo/fingerprint@0.21.10, which requests^10.2.6and matches with{ dot: true }. There is no patched 10.x release. 11.0.9 is the latest, and minimatch 11 changes globstar and extglob matching, which changes fingerprint hashes. Expo declined that upgrade in chore(fingerprint): Dropgloband addminimatch@^10usage note expo/expo#53091. The advisory's amplification runs whenoptimizationLevelis 2 or higher, and fingerprint leaves the default at 1.yargs@17.7.2, AIKIDO-2026-922647 (low). KNO-16335. The fix is in 18.1.0. 17.7.3 does not include it, and itsapply-extends.jsis byte-identical to 17.7.2. Today's React Native nightly,react-native@0.89.0-rc.1, Metro 0.88.0, and@react-native/codegenstill requestyargs@^17.6.2. Yargs 18 is ESM-only, and Metro's CLI still callsrequire("yargs").ws@6.2.3andws@7.5.10are still installed and were not reported.Todos
None.
Checklist
Screenshots or videos
Not applicable.