Skip to content

fix: resolve ws 7.5.10 to 7.5.14 - #1133

Merged
andy-knock merged 2 commits into
mainfrom
cjbell-vulnerable-javascript-dependencies-5d31
Nov 19, 2026
Merged

andy-knock merged 2 commits into
mainfrom
cjbell-vulnerable-javascript-dependencies-5d31

Conversation

@cursor

@cursor cursor Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Description

Resolve the open Vanta finding for ws on the javascript repository.

Vanta reports AIKIDO-2026-844803 (low) on ws@7.5.10. A peer that has completed the WebSocket handshake can exhaust memory by flooding Ping frames while reads are paused, so automatic Pong responses queue without a cap. Aikido marks 7.0.0 through 7.5.13 affected and fixes that line in 7.5.14 (published 2026-11-12), which adds maxPendingAutoPongs (default 60). react-native@0.88.1, Metro 0.82 and 0.87, @react-native/dev-middleware@0.88.1, and react-devtools-core 6.1.x already request ws@^7 or ws@^7.5.10. 7.5.14 is inside both ranges, so the root resolutions pin those descriptors to 7.5.14. ws@^8.12.1 stays on 8.23.0. ws@6.2.3 was not in this scan and is unchanged.

Linear: https://linear.app/knock/issue/KNO-16910/js-upgrade-ws-from-7510-to-7514

The same scan still reports two findings this pull request does not change, because there is no compatible patched release:

Todos

None.

Checklist

  • Tests have been added for new features or major refactors to existing features.

Screenshots or videos

Not applicable. This is a lockfile resolution.

Open in Web View Automation 

Vanta reports AIKIDO-2026-844803 on ws 7.5.10. 7.5.14 is inside the ranges React Native, Metro, and React DevTools already request.

Co-authored-by: Chris Bell <chris@cjbell.co>
@cursor
cursor Bot requested a review from a team as a code owner November 19, 2026 12:07
@cursor
cursor Bot requested review from kylemcd and meryldakin and removed request for a team November 19, 2026 12:07
@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
javascript-ms-teams-connect-example Ready Ready Preview Nov 19, 2026 2:14pm UTC
javascript-nextjs-example Ready Ready Preview Nov 19, 2026 2:14pm UTC
javascript-slack-connect-example Ready Ready Preview Nov 19, 2026 2:14pm UTC
javascript-slack-kit-example Ready Ready Preview Nov 19, 2026 2:14pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bb9b9e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@knocklabs/expo Patch
@knocklabs/react-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear-code

linear-code Bot commented Nov 19, 2026

Copy link
Copy Markdown

KNO-16910

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR meets the dependency-update approval policy: it pins ws 7.5.10 to 7.5.14 and core CI is green. GitHub blocked an approval from this automation because it authored the PR, so no approval was recorded.

Open in Web View Automation 

Sent by Cursor Approval Agent: SDK approver

@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.63%. Comparing base (3eaee00) to head (bb9b9e5).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1133   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files         142      142           
  Lines        4540     4540           
  Branches     1319     1319           
=======================================
  Hits         3570     3570           
  Misses        873      873           
  Partials       97       97           

@andy-knock
andy-knock merged commit 32c7a03 into main Nov 19, 2026
15 checks passed
@andy-knock
andy-knock deleted the cjbell-vulnerable-javascript-dependencies-5d31 branch November 19, 2026 14:19

This branch was successfully deployed

4 active deployments
Preview – javascript-ms-teams-connect-example — bb9b9e5f Deployed Nov 19, 2026 by vercel[bot]
Preview – javascript-nextjs-example — bb9b9e5f Deployed Nov 19, 2026 by vercel[bot]
Preview – javascript-slack-connect-example — bb9b9e5f Deployed Nov 19, 2026 by vercel[bot]
Preview – javascript-slack-kit-example — bb9b9e5f Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants