Repository navigation
site: move to 1.3.0 and resync the compose copy from upstream - #91
Open
yusuf-gundogdu wants to merge 1 commit into
Open
yusuf-gundogdu wants to merge 1 commit into
yusuf-gundogdu wants to merge 1 commit into
Conversation
The version line goes to 1.3.0. The compose page's copy of docker-compose.example.yml was taken from an older upstream than the tag claimed, so three things on the page were wrong: - LLM_MODEL_EFFORT was missing, so the variable table omitted a variable the image reads. - The node version read 26.10.0; the Dockerfile at 1.3.0 builds the runner FROM node:26.13.0-trixie-slim, and the correction's reason still cited 0.18.3. - upstreamCompose.sha256 was the hash of the stale copy restored, not of upstream, so the gate compared the file with itself. The copy is rebuilt from upstream 1.3.0 with the same six comment corrections, moved to their new line numbers, and sha256 is now upstream's own hash.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version line goes to 1.3.0.
While checking that, the compose page turned out to be serving an older upstream than the tag claimed. Three things on it were wrong:
LLM_MODEL_EFFORTwas missing from the copied file, so the variable table on /docker-compose omitted a variable the image reads.upstreamCompose.sha256was the hash of the stale copy with its corrections reverted, not of upstream, so the gate was comparing the file with itself and could not catch the drift.The copy is rebuilt from upstream 1.3.0 with the same six comment corrections, moved to their new line numbers (the MCP comment block grew by two lines, so 129 became 132), and sha256 is now upstream's own hash.
Checked locally with bun 1.4.2: typecheck 0 errors, format clean, lint unchanged, build complete, 233 tests pass.