Skip to content

Fix TXNOW example to use SET - #49

Closed
chris-lightbug wants to merge 1 commit into
mainfrom
fix/txnow-example-set
Closed

chris-lightbug wants to merge 1 commit into
mainfrom
fix/txnow-example-set

Conversation

@chris-lightbug

@chris-lightbug chris-lightbug commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Correct only the encoded method in the Transmit Now request example from removed DO (4) to SET (1).
  • Recompute CRC16-XMODEM: trailing bytes 180 28 become 196 222.
  • Preserve message ID, payload foo, length, method schema and all other documentation.

The schema already advertises SET; this fixes the raw example bytes, not the method definition. Canonical firmware YAML correction: https://github.com/lightbug-io/firmware-st/pull/101. No merge or deployment performed.

Validation

  • Executed repository parseRawMessage and calculateCRC16XMODEM under Node 24.
  • Original and fixed CRCs validate; decoded method changes 4 to 1; MT30, length, message ID and foo payload preserved.
  • Only byte indexes 10, 20, 21 changed.
  • YAML parsing passed.
  • Full site build/Jest not run: no full checkout/dependencies available; connector-level one-line change only.

@addshore

addshore commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Moving this to the "other" repo

@addshore addshore closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants