Repository navigation
release: ls-plugin - Release v1.0.0 - #31
Conversation
- Added a new block for switching between light and dark styles. - Created block.json to define block metadata and settings. - Implemented edit and save functions for the block, including inspector controls for size selection. - Added icons for light and dark modes using SVG components. - Developed CSS styles for the switcher, including responsive design for different sizes. - Integrated JavaScript functionality to handle style preference persistence and UI updates. - Ensured accessibility features such as ARIA attributes for better usability.
…cal storage integration
- Introduced `iconBehavior` attribute in block.json to manage icon display behavior. - Updated the edit and save functions to handle the new `iconBehavior` attribute. - Enhanced the InspectorControls to allow users to select between "Current Style Icon" and "Switch-To Style Icon". - Modified CSS styles to reflect changes in icon visibility based on the selected icon behavior. - Updated RTL and standard CSS files to ensure consistent styling across different modes.
[Feature] Style Switcher: selectable variations and icon behaviour (Closes #3)
- Implemented a new Back to Top block that allows users to scroll back to the top of the page with a smooth animation. - Added block metadata and registration in the plugin. - Created editor and frontend scripts for the block, including inspector controls for customizable button label, position mode, and scroll threshold. - Developed styles for both normal and RTL layouts, ensuring accessibility and responsiveness. - Included JavaScript utility for smooth scrolling and sticky header detection. - Documented the block's features, usage, and customization options in README.md.
- Deleted the Back to Top block files including block.json, edit.js, save.js, and styles. - Registered a new "Back to Top" variation for the core/button block with attributes for position mode and scroll threshold. - Added smooth scrolling functionality for the Back to Top button, ensuring accessibility and performance. - Implemented styles for the Back to Top button variation, handling visibility and transitions based on scroll position.
…ed visibility and performance
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Warwick Booth <krugazul@users.noreply.github.com>
feat: button icon and back-to-top variation improvements
…nto linkable-blocks
Add linkable blocks functionality
…nd taxonomy configurations
…et-of-phosphor-svg-icons Register LightSpeed SVG icon collection (WP 7.1) and namespace inc/ classes
Icons Added - 34 icons sourced from Phosphor core (regular weight), fill-based per collection convention - 1 custom solid dot icon (dot.svg) for section badge bullet markers Coverage - Closes the icon gap identified by auditing all outermost/icon-block usage across ls-theme patterns/parts - Covers icons from the currently merged theme branch plus feature/ls-2594-search-template and feature/ls-1598-build-services-page - Reuses existing lightspeed icons (arrow-right, cart, credit-card, gift, quote) instead of duplicating matches already in the collection Context - Built on feature/ls-3224-register-a-set-of-phosphor-svg-icons (LS-3224) as a stacked branch - Tracked under LS-3228
…tiser Bug - All 34 Phosphor-sourced SVGs had fill="currentColor" on the <svg> root instead of the <path> - dot.svg had no fill at all - The icon sanitiser strips fill from <svg>, so every new icon was rendering solid black instead of inheriting currentColor Fix - Moved fill="currentColor" from <svg> to <path> on all 34 sourced icons - Added fill="currentColor" to dot.svg's <path> - Matches the convention already documented in assets/icons/lightspeed/README.md and used by existing icons (cart.svg) Context - Addresses review feedback on PR #21
…ng-lightspeed-icons Add missing icons sourced from Phosphor for the lightspeed collection
…#23) * Restore project/project-group taxonomy naming to match LIVE (LS-3725) Bug fix - Restore post_type_portfolio.json: post_type back to "project", taxonomies back to ["project-type","project-tag","project-group"] - Restore group_ls_plugin_portfolio_fields.json: location rule back to "project", re-add the dropped "Client Name" field - Remove stale duplicate taxonomy files (taxonomy-portfolio-industry.json, taxonomy-portfolio-service.json) Context - A prior commit (bfaf343) accidentally reintroduced the pre-PR #18 ls_plugin_portfolio/industry/service naming from a stale local SCF export, breaking the /portfolio/ archive on the theme (which is built entirely against the project/project-group naming) - This restores PR #18's LIVE-aligned naming exactly; no PHP changes needed as class-permalinks.php/class-portfolio-terms.php were never affected by the accidental revert * Add CHANGELOG entry for portfolio taxonomy naming fix (LS-3725) Context - Documents the /portfolio/ 404 fix from PR #23 per this repo's changelog requirement (AGENTS.md) * Add versioned one-time rewrite flush for portfolio restoration (LS-3725) Bug fix - Add Permalinks::maybe_flush_rewrite_rules(), hooked on `init` at priority 30 (after SCF/ACF registers the post type/taxonomies) - Flushes rewrite rules exactly once, tracked via a versioned option (ls_plugin_portfolio_rewrite_flushed_version / REWRITE_FLUSH_VERSION) Context - Addresses PR #23 review feedback: restoring the `project` registration doesn't itself refresh rewrite rules cached under the previously reverted `ls_plugin_portfolio` registration - Any environment that never manually resaved Permalinks would keep 404ing on /portfolio/ even after this fix merges — this makes recovery automatic instead of relying on a manual step - Scoped to rewrite rules only (no taxonomy/term data touched), unlike the automated post/term migration PR #18 deliberately removed due to duplicate-term risk on existing tagged content
Icons Added - notepad.svg - clipboard-text.svg - github.svg - rocket-launch.svg - buildings.svg Source - Pulled from phosphor-icons/core assets/regular, byte-matched against the embedded SVGs already used in ls-theme's skipped icon-block instances - fill="currentColor" placed on <path>, matching the sanitizer-safe convention documented in assets/icons/lightspeed/README.md Context - Closes the remaining gap in LS-3229's "Missing icons" tracking list - Auto-registered by LS_Plugin\Icons on init — no PHP changes needed
Context - Documents the 5 new lightspeed icons added in PR #24
…ning-lightspeed-icons Add remaining missing icons sourced from Phosphor for the lightspeed collection
Setup - Run specify init with the Copilot integration, adding skills under .github/skills/ - Add the Claude integration alongside it under .claude/skills/ - Add shared .specify/ scripts and templates powering both Context - Direct commit to develop per request Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
* Fix lightspeed/dot icon rendering too small Bug fix - Enlarge dot.svg circle to fill its 256x256 viewBox (r=28 -> r=128) - Fixes excessive transparent padding causing undersized eyebrow dots Context - Reported in LS-4168 - Affects footer, homepage, blog, work, 404, and Services page eyebrow bullets - No theme-side changes needed; icon is auto-registered from assets/icons/lightspeed/ Changelog - Added Fixed entry under [Unreleased] in CHANGELOG.md * Fix lightspeed/dot icon rendering too small Bug fix - Enlarge dot.svg to fill its 256x256 viewBox (r=28 -> r=128) - Draw the circle as a path, not a <circle> element, since WP_Icons_Registry's wp_kses() sanitizer only allows svg/path/ polygon tags and silently strips circle/rect on render - Fixes excessive transparent padding causing undersized eyebrow dots Context - Reported in LS-4168 - Affects footer, homepage, blog, work, 404, and Services page eyebrow bullets - No theme-side changes needed; icon is auto-registered from assets/icons/lightspeed/ Changelog - Updated Fixed entry under [Unreleased] in CHANGELOG.md * Link PR #25 in dot.svg changelog entry Context - CHANGELOG.md convention links merged/opened PRs from Fixed entries - References #25 for LS-4168 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
… collection (#26) * Add missing Phosphor icons to lightspeed collection Icons - Add circle.svg, coins.svg, hard-drives.svg, chart-bar.svg - Add users-three.svg, paper-plane-tilt.svg - Add git-fork.svg, chat-circle-dots.svg Context - Sourced from phosphor-icons/core regular weight - Fills gaps found while cross-checking design mockups against the existing lightspeed icon set * Document new lightspeed icons in CHANGELOG Context - Adds an Unreleased entry for PR #26's 8 new icons - Follows this repo's Keep a Changelog convention Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
* Add Post Types settings tab to enable plugin post types (LS-4288) Adds a Settings > LightSpeed options page (SCF) with a "Post Types" tab that dynamically lists post types defined in scf-json/. Unchecked post types are unregistered after SCF registers them, so Portfolio is now disabled by default. Rewrite rules are flushed when the settings save. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Disable portfolio taxonomies and permalink fields with their post type (LS-4288) Taxonomies defined in scf-json/ are unregistered when every plugin post type they attach to is disabled. The Portfolio permalink slug fields are only registered and saved while the project post type is enabled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…(LSA-191) (#28) * feat: lefthook - Add a pre-commit PHP check and build for the plugin (LSA-191) Lefthook - Add lefthook.yml with a piped pre-commit hook - Skip the hook during merges and rebases - Ignore lefthook-local.yml for personal overrides PHP check job - Run php -l on each staged PHP file, then phpcs on the staged files - Errors block the commit, warnings do not - Skip build/ and vendor/ files - Fail with a clear message if php or phpcs is missing Build job - Run npm run build when files in src/ or webpack.config.cjs are staged - Stage the whole build/ folder, as webpack runs with clean: true - Stop if src/ has unstaged changes or untracked files - Block git commit <file>, which drops staged files from the real index - Fail with a clear message if npm or node_modules is missing PHP ruleset - Add phpcs.xml.dist for PHP files only, skipping vendor, node_modules and build - Switch off 13 auto-fixable formatting sniffs the existing code breaks - Report 8 judgement-call findings as warnings - Keep security sniffs on, excluding two false positives for one file each - Existing code now has 0 errors and 70 warnings Composer and dependencies - Point the phpcs and phpcbf scripts at the ruleset, fixing the out-of-memory crash - Add lefthook as a devDependency and update package-lock.json Docs - Add .github/reports/lefthook-setup.md with install, usage, bypass, limits and verification - Add the CHANGELOG entries under Unreleased Verification - 24 real git commit scenarios in a scratch worktree: valid, blocked and edge cases - A pure rebuild gives no difference from the committed build/ - composer run phpcs, phplint, plugin:validate, schema:validate and security:scan pass - npm audit is unchanged at 122 findings * fix: lefthook - Replace file-wide phpcs security exclusions with inline ignores (LSA-191) Security sniffs - Remove the file-wide exclusions for search-filter/render.php and class-permalinks.php - Suppress the two known false positives inline, with a reason, on those statements only - A new violation elsewhere in those files is now blocked by the PHP check - Correct the sniff name in class-permalinks.php to ValidatedSanitizedInput - Rebuild build/ so its copy of render.php matches the source Docs - Remove the incorrect known limit that deleting a source file skips the build job - Document that deletions trigger the build and stage the removal of built output - Describe the inline suppressions in the setup report - Add verification rows for the strictness and deletion cases - Update the CHANGELOG entries Verification - New unescaped output and new unsanitised input in those files are blocked - A harmless edit to those files passes - Deleting an imported file blocks the commit, as the build fails - Deleting a whole block commits the removal of its files from build/ - Deleting an unused file passes, with the commit holding only the deletion - phpcs on the whole repo reports 0 errors Review - Addresses the CodeRabbit comments on phpcs.xml.dist and lefthook.yml
…f the site search (#29) * fix: launch-search-exclude-noindex - Keep Yoast-noindexed pages out of the site search Why - Pages set to noindex are hidden from Google but still found by WordPress's own search - Pages that are not ready for launch cannot be unpublished, so noindex is the plan - Core search ignores Yoast's noindex setting, so the site search needed a filter Search filter - Add inc/class-search-noindex-exclude.php with the LS_Plugin\Search_Noindex_Exclude class - Exclude posts where _yoast_wpseo_meta-robots-noindex is 1 from the main front-end search - Apply the same rule to Query Loop blocks that are searching - Keep posts with no noindex setting, or set to index, searchable - Run after the Search Filter block (priority 1000) so block-set search terms are covered - Leave admin and REST searches untouched, so the editor link search still finds everything - Add the ls_plugin_search_exclude_noindex filter to switch the behaviour off Bootstrap and docs - Load the class and instantiate it in ls-plugin.php - Add the CHANGELOG.md entry under Unreleased Context - Part of LSA-220 (pre-launch audit findings), section B - Needs the per-page noindex flag from the database plan (section C) to have any effect - Tested locally: noindexed page hidden, unset and index pages shown, in main search and Query Loop * docs: changelog - Link PR 29 in the search noindex entry Changelog - Add the PR link to the Yoast noindex search filter entry Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix: launch-search-exclude-noindex - Apply the noindex clause to custom-field searches CodeRabbit finding - A custom-field search from the Search Filter adds a meta_query and leaves s empty - The noindex filter only checked s, so it skipped those searches Search Filter - Add the SEARCH_APPLIED_QUERY_VAR constant - Set it on the main query and on Query Loop queries when a custom-field search is applied Noindex filter - Treat a query as a search when s is set or the Search Filter flag is set - Keep unrelated queries unfiltered and keep the is_enabled() check Testing - Custom-field search: flag set and noindex clause added in the main query and Query Loop - Unrelated queries: no noindex clause added - PHPCS reports 0 errors Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
* Scope lint to authored source and document lint suppressions
Stylelint scope
- Lint only src/**/*.{css,scss} instead of every file under src/
- Add .stylelintignore for compiled src/**/style.css and *.map outputs
- Keep hand-written src/css/linkable-blocks.css linted
ESLint
- Declare browser globals used in back-to-top/view.js
- Disable no-unsafe-wp-apis with a reason where no stable component exists
* Apply ESLint, Prettier and Stylelint auto-fixes to src
Auto-fix
- Run wp-scripts lint-js --fix on src (Prettier formatting, curly braces)
- Convert var to let/const in linkable-blocks editor and frontend scripts
- Use object shorthand and add missing JSDoc params
- Run wp-scripts lint-style --fix on src SCSS and linkable-blocks.css
Review notes
- Checked for use-before-define, block-scoped and loop-closure issues
- Kept the 'Loading...' string as-is (the i18n-ellipsis fix would change a translatable string)
* Fix remaining ESLint and Stylelint errors by hand
JS
- Remove unused useSelect import and linkTarget variables
- Keep three console.error calls with a documented no-console disable
- Add JSDoc types to the taxonomy-filter edit props
- Use document.defaultView.getSelection() in the linkable-blocks frontend script
- Move getContext() after the early return in search-filter-view-module
- Merge let declarations into const in linkable-blocks frontend handlers
- Keep editor-only preview anchors link-less with a documented disable
- Keep the 'Loading...' string with a documented i18n-ellipsis disable
Unused code kept for review
- carousel hasChildBlocks and taxonomy-filter debounceTimers kept with a documented disable
SCSS
- Reorder rules only where no shared property or higher specificity changes the cascade
- Merge the duplicate back-to-top link block
- Wrap an over-long comment in taxonomy-filter
* Add changelog entry for the lint fixes
* Link the lint-fix changelog entry to its pull request
Version - Set 1.0.0 in ls-plugin.php (header and LS_PLUGIN_VERSION), package.json and package-lock.json - Add VERSION file containing 1.0.0 - Set readme.txt Stable tag to 1.0.0 and Tested up to 7.0 Changelog - Move Unreleased into [1.0.0] - 2026-11-02 and keep a fresh Unreleased section - Add a BREAKING CHANGES section and fix the compare links - Add the 1.0.0 entry to the readme.txt changelog Docs - Add ADR-001 for the 1.0.0 breaking changes - Add docs/migrating-to-1.0.md Refs LSA-181 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Release Pull Request
Linked issues & merged PRs
Related to Linear LSA-181 (release ls-plugin v1.0.0, released together with ls-theme for the full site redesign).
Includes: everything merged into
developsincemain, including #2, #4 to #15, #17 to #21 and #23 to #30. All of it was reviewed in those PRs.Review scope and merge method
bebaf21, 8 files, +149 / −9 againstdevelop). The rest of this diff againstmain(332 files) is the content of the earlier PRs above and was already reviewed there.develophistory into one commit.v1.0.0tag is created by hand after the merge. This branch has no tag.What the release commit changes
1.0.0inls-plugin.php(header andLS_PLUGIN_VERSION),package.json,package-lock.json(both root entries), and a newVERSIONfile.readme.txt:Stable tag: 1.0.0,Tested up to: 7.0, new= 1.0.0 =entry.CHANGELOG.md:[Unreleased]moved into## [1.0.0] - 2026-11-02, a fresh[Unreleased]added, a⚠️ BREAKING CHANGESsection added, and the[1.0.0]link set toreleases/tag/v1.0.0. One stale entry was removed: "Changed Back to Top visibility to always display". The code shows Sticky and Fixed modes still show and hide by scroll threshold, so that entry was wrong.docs/adr/ADR-001-release-1-0-breaking-changes.mdanddocs/migrating-to-1.0.md.Breaking changes
Each was checked against the code. See the migration guide for upgrade steps.
inc/are underLS_Plugin\, with no aliases for the oldLS_Plugin_*names.core/buttonvariation.mainstill holds the original starter (0.1.0) and there are no earlier tags or releases, so these affect sites running pre-releasedevelopbuilds.Changelog
meta:needs-changelog. The full 1.0.0 entry list is in CHANGELOG.md.Added
See
CHANGELOG.md→[1.0.0]→ Added (28 entries).Changed
See
CHANGELOG.md→[1.0.0]→ Changed (12 entries).Fixed
See
CHANGELOG.md→[1.0.0]→ Fixed (9 entries).Removed
Verification
npm run lint,plugin:validate,schema:validate,security:scan,scan-placeholders,composer run phplintandcomposer run phpcsall exit 0 on this branchv1.0.0created by hand after mergeChecklist (Global DoD / PR)