Repository navigation
[Next] Keep provider artwork decoder crashes from terminating Hypnotix - #444
Open
MarkusRink wants to merge 1 commit into
Open
MarkusRink wants to merge 1 commit into
MarkusRink wants to merge 1 commit into
Conversation
clefebvre
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
codex sol 6.1 on behalf of Markus:
Provider logos and posters are decoded inside the GTK process. If a native image decoder aborts, Python exception handling cannot prevent Hypnotix from terminating.
Decode provider artwork in a separate process and pass validated RGB/RGBA pixels back to GTK. If decoding fails, aborts, or times out, use the existing fallback image. Finish writing downloaded artwork before requesting its decode.
Validation: seven unittest tests cover RGB/RGBA scaling, corrupt and missing files, a native decoder abort, timeout handling, invalid pixel data, oversized files, and cache invalidation.
Run: PYTHONDONTWRITEBYTECODE=1 /usr/bin/python3 -m unittest discover -s tests -v
Checked against all 19 currently open PRs on 2026-11-06. No equivalent decoder isolation was found. PR #435 changes the fallback resource path in the same method; this change leaves that fallback line intact. This contribution contains no Xtream or cache-recovery changes from PR #404.