Repository navigation
Fix build: bump Ruby to 3.4.12 and set RAILS_ASSETS_PRECOMPILE - #27
Closed
JeffreyBytes wants to merge 1 commit into
Closed
JeffreyBytes wants to merge 1 commit into
JeffreyBytes wants to merge 1 commit into
Conversation
|
Thanks for opening this pull request! Be sure to follow the pull request template! |
Member
|
Already addressed in #26 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Two changes to both Dockerfiles, plus a changelog entry in
readme-vars.yml.ruby:3.4.9-alpine3.24toruby:3.4.12-alpine3.24. Upstream v0.154.0 moved.ruby-versionto 3.4.12, and the Gemfile reads it (ruby file: ".ruby-version"), sobundle installcurrently fails with "Your Ruby version is 3.4.9, but your Gemfile specified 3.4.12".RAILS_ASSETS_PRECOMPILE=1forrake assets:precompile. Since v0.151.0,config/initializers/cache_clearance.rbclears a Redis cache on boot unless that variable is set. Upstream's owndocker/build.dockerfilesets it for precompile. Without it, precompile tries to reach Redis on localhost:6379 during the build and fails withRedis::CannotConnectError.Benefits of this PR and context:
The image hasn't published since v0.150.0. Every build from v0.151.0 onward fails at asset precompile because of the Redis connection, and v0.154.x also fails earlier on the Ruby version mismatch (CI build 1030). With both changes, the current upstream release builds and runs.
How Has This Been Tested?
Tested on CachyOS (x86_64) with Docker.
Built v0.154.1 with these changes:
The build completed, including
bundle installandassets:precompile.Ran the image with SQLite (
DATABASE_URL=sqlite3:/config/manyfold.sqlite3) and a Valkey 8 container forREDIS_URL. Init completed ([ls.io-init] done.), the web UI loaded on port 3214, and the container restarted cleanly against the existing /config.I didn't build aarch64 locally. The changes are identical in both Dockerfiles and nothing is architecture-specific.
AI disclosure: I used Claude (Anthropic) to help trace the CI failures to these two causes and to draft this description. I made, built and tested the changes myself.
Source / References:
RAILS_ASSETS_PRECOMPILEcheck: manyfold3d/manyfold@3caffcb