Skip to content

docs: keep AGENTS guidance repository-scoped - #136

Open
xnoto wants to merge 5 commits into
mainfrom
docs/scope-agent-instructions
Open

xnoto wants to merge 5 commits into
mainfrom
docs/scope-agent-instructions

Conversation

@xnoto

@xnoto xnoto commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove duplicated headless-session and MCP rules from the chart monorepo guide. Point to the chart-owned policy and retain repository CI and chart delivery rules.

Approved in the owner discussion. No issue to close.

Type of change

  • Bug fix
  • Feature / enhancement
  • Documentation
  • Infrastructure (OpenTofu root or module)
  • GitOps desired state (manifests, kustomize, charts, SOPS/KSOPS secrets)
  • Container image
  • CI / reusable workflow
  • Refactor / cleanup
  • Breaking change

Validation

Reviewed the scope of the documentation diff. PR CI pending; merge only on passing checks. No local or live validation.

  • Required pull-request checks pass
  • Generated or centrally distributed files were regenerated by their owning automation, not hand-edited

Impact and rollout

No packaged chart files or versions change. No OpenCode publication, GitOps pin change, or runtime rollout is requested.

Safety and secrets

  • Contains no plaintext secrets, decrypted SOPS values, state files, kubeconfigs, tokens, or private endpoints
  • No local OpenTofu init/plan/apply/destroy/import/state operations were run or claimed — plans come from pull-request checks
  • Breaking or irreversible effects are described above with rollback notes

An AI agent prepared this change; the completed diff received independent review.

@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Chart CI failed

View the workflow run

Validation output (redacted, last 12000 characters)
### hygiene.log
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/gitleaks/gitleaks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
[INFO] Installing environment for https://github.com/gitleaks/gitleaks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
check for merge conflicts................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
Detect hardcoded secrets.................................................Passed


### helm.log
==> Linting agent-pipe-uploader
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed
==> Linting opencode-server
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed
make[1]: Entering directory '/home/runner/work/charts/charts'
make[1]: Leaving directory '/home/runner/work/charts/charts'
make[1]: Entering directory '/home/runner/work/charts/charts'
make[1]: Leaving directory '/home/runner/work/charts/charts'
make[1]: Entering directory '/home/runner/work/charts/charts'
....F...............................................................
======================================================================
FAIL: test_docs_and_root_consumer_contract (__main__.CodebaseMemoryConsumerContract.test_docs_and_root_consumer_contract) (path='/home/runner/work/charts/charts/AGENTS.md')
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/charts/charts/opencode-server/tests/test_memory_pilot_render.py", line 799, in test_docs_and_root_consumer_contract
  self.assert_policy(handle.read())
  ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/home/runner/work/charts/charts/opencode-server/tests/test_memory_pilot_render.py", line 779, in assert_policy
  self.assertIn(marker, text, marker)
  ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'exact advertised schemas FIRST' not found in '# Agent Instructions ## Repository Purpose Helm chart monorepo for Make IT Work Cloud workloads. Every direct child directory containing `Chart.yaml` is an independently validated chart. Merges to `main` publish changed charts as OCI artifacts to GHCR. OpenCode runtime policy is owned by the [opencode-server chart](opencode-server/docs/agent-instruction-architecture.md), not by this repository guide. Use repository CI as the validation authority for chart changes. ## Workflow Use feature branches and pull requests. Agents may create a scoped branch, commit, push, and open a pull request for an authorized repository change without requesting a separate confirmation. Inspect protected-branch metadata, PR templates, reviews, and check runs, and never bypass protections. Explicit user approval remains required before merging, publishing a package, dispatching a workflow, deploying, or mutating a live system. Before publishing, inspect proposed changed files for secrets, state, kubeconfig material, decrypted SOPS values, tokens, credentials, private keys, and sensitive plan output. ## Chart conventions - Use [Adding a chart](docs/adding-a-chart.md) for the authoring and release procedure. Use [GitOps update automation](docs/gitops-update-automation.md) for the optional post-publish pull request contract. - Keep each chart self-contained below its chart directory. - Do not place plaintext credentials, kubeconfigs, tokens, or decrypted SOPS values in charts or values files. - Cluster-owned secrets, namespaces, storage, and shared networking remain in `kustomize-cluster` unless a migration explicitly moves their ownership. - Add `<chart>/README.md` for chart-specific ownership, values, prerequisites, and usage; update it when that contract changes. CI discovers direct-child charts automatically. - Every `opencode-server/files/` content change — configuration, `AGENTS.md`, `agents/*.md`, `skills/*/SKILL.md` — requires an `opencode-server/Chart.yaml` version bump because OCI chart versions are immutable. - After `opencode-server` publishes, automation opens or updates a `kustomize-cluster` version-pin pull request with auto-merge enabled; see [GitOps update automation](docs/gitops-update-automation.md) for the current contract. Argo CD reconciliation and rollout health are verified separately afterward.' : exact advertised schemas FIRST

----------------------------------------------------------------------
Ran 68 tests in 1.448s

FAILED (failures=1)
make[1]: *** [Makefile:306: test-opencode-server-memory-pilot] Error 1
make[1]: Leaving directory '/home/runner/work/charts/charts'
make: *** [Makefile:26: test] Error 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant