Repository navigation
Warn when the metadata Raft WAL has no checkpoint interval, and test the compacting append under failure - #640
Merged
Conversation
With MATRIXOBJECT_METASERVER_RAFT_CHECKPOINT_BYTES unset the metadata WAL is never truncated and refuses appends at 512 MiB; a log workload reached that after about 2,770 appends. The metaserver now says so at startup and the configuration guide documents the variable as required for such workloads. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tadata leader Process-level: with a star member dead the compaction is refused and the manifest and bytes are unchanged; with the metadata leader dead the object is exactly before or exactly after, an acknowledged append is published, and an unpublished one retries cleanly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The message literal carried runs of spaces from a lost line continuation. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three small changes that make the compacting log append safe to operate.
MATRIXOBJECT_METASERVER_RAFT_CHECKPOINT_BYTESunset(its default,
0), the metadata Raft WAL is never truncated and a voter refusesappends once it reaches 512 MiB. The metaserver now says so at startup when Raft is
configured and the variable is unset.
workload that publishes many objects or appends to log objects.
append_object_compacting(merged in Keep a log object appendable past its extent bound #639).Why
Measured on a real three-metaserver, three-chunkserver star group with 300-byte
appends and full-manifest publication: with checkpointing off, the three voters wrote
about 2 GB of WAL in total and all exited after about 2,770 appends. The cause is
visible only in the voter's own log, so an operator has no way to find it before the
cluster stops. The warning and the guide section put the setting where it is needed.
Crash tests
are unchanged.
acknowledged append is published, and an unpublished one retries cleanly.
They run in the existing
node_regimetest group, one process-level fixture at a time.Not changed
No behaviour changes when the variable is set. The warning is printed to standard
error and does not alter how the metaserver starts.
🤖 Generated with Claude Code