Repository navigation
Conversation
Contributor
Author
3 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free-form text area
@farhi FYI
Updates the
%Testvalues ofSOLEIL_CRISTALandSOLEIL_MARS, which have been off onmainsince #3088 (see #3091):SOLEIL_CRISTALSOLEIL_MARSBoth use
FluoPowder, which inherits theFluorescencecode changed in #3088. The new values are those reported by the full-suite CI run 43027588188, identical on Linux (gcc), macOS (clang) and Windows (MSVC).Needs a physics check before merge: the values change by a factor 2.5-3. This PR assumes that is the intended effect of the normalisation fix in #3088; that has not been verified independently.
Declaration of use of AI-tools
Development OS / boundary conditions
Edited on macOS. Not run locally; the new values are taken from the CI logs (Linux, macOS, Windows). The CI of this PR re-runs both instruments.
PR Checklist for contributing to McStas/McXtrace
My contribution includes patches to an existing instrument file
mcdocutility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)mctestutility to test the instrument (please attachmcviewtestreport as screenshot in comments)mcrun --c-lint"linter" and followed advice to remove most / all warnings that are raisedMy PR is meant to fix a specific, existing issue
INHERITtest-scope item stays open)🤖 Generated with Claude Code