Skip to content

X: SOLEIL_CRISTAL, SOLEIL_MARS: update test values after Fluorescence fix - #3092

Open
willend wants to merge 1 commit into
mainfrom
soleil-fluopowder-test-values
Open

willend wants to merge 1 commit into
mainfrom
soleil-fluopowder-test-values

Conversation

@willend

@willend willend commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Free-form text area

@farhi FYI

Updates the %Test values of SOLEIL_CRISTAL and SOLEIL_MARS, which have been off on main since #3088 (see #3091):

Instrument Old New
SOLEIL_CRISTAL 6.2037e+05 1.53764e+06
SOLEIL_MARS 1.341e+08 4.17087e+08

Both use FluoPowder, which inherits the Fluorescence code changed in #3088. The new values are those reported by the full-suite CI run 43027588188, identical on Linux (gcc), macOS (clang) and Windows (MSVC).

Needs a physics check before merge: the values change by a factor 2.5-3. This PR assumes that is the intended effect of the normalisation fix in #3088; that has not been verified independently.


Declaration of use of AI-tools

  • Please add a checkmark here if you used AI-tools during the work for this contribution
  • Furter, please describe how / where and for what the tools were used: Claude Code analysed the failing CI logs, traced the cause and prepared the issue and this change.

Development OS / boundary conditions

Edited on macOS. Not run locally; the new values are taken from the CI logs (Linux, macOS, Windows). The CI of this PR re-runs both instruments.


PR Checklist for contributing to McStas/McXtrace

  • My contribution includes patches to an existing instrument file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)
    • I have used the mctest utility to test the instrument (please attach mcviewtest report as screenshot in comments)
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised
  • My PR is meant to fix a specific, existing issue


🤖 Generated with Claude Code

… fix

Both use FluoPowder, which inherits the Fluorescence code changed in #3088.
Refs #3091

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@willend

willend commented Nov 11, 2026

Copy link
Copy Markdown
Contributor Author

@farhi building in a solution to catch INHERIT statements in mctest on #3093

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant