Repository navigation
Make options required in MutationObserver.observe() - #2578
Merged
github-actions[bot] merged 2 commits intoNov 3, 2026
Merged
github-actions[bot] merged 2 commits into
github-actions[bot] merged 2 commits into
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Thanks! LGTM. |
Contributor
|
Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks! |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2566
observe()throws aTypeErrorwhenever none ofchildList,attributesorcharacterDataends up true, so callingobserve(target)without options always throws (covered by WPT indom/nodes/MutationObserver-sanity.html). As discussed in the issue, this makes theoptionsparameter required, which flags that mistake at compile time without affecting code that works at runtime.Since the KDL patch format didn't support
optionalon method parameters yet, this PR also adds that tohandleParaminsrc/build/patches.ts(one line), then uses it ininputfiles/patches/dom.kdl. If you'd prefer this override inoverridingTypes.jsoncinstead, I'm happy to move it.Note: this only covers calling
observe(target)without options. Options objects that don't meet the minimum requirements, such as{}or{ subtree: true }, are still accepted by the type and throw at runtime, so I'm not closing the issue with this PR.