Repository navigation
fix(ensemble-manager): saving a region that already exists succeeds - #414
Merged
Merged
Conversation
POST /regions inserts the region with its geometry row nested under it. When the region already exists (the same area submitted twice) the insert hits ON CONFLICT DO NOTHING and Hasura refuses to insert the nested row, so the second save failed with REGION_WRITE_FAILED instead of answering created: false. insertRegionIfAbsent now treats that error as already present.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting the same area twice from SUBSIDE fails at the region step (
The region could not be saved,REGION_WRITE_FAILED).POST /regionsinserts the region with its geometry row nested under it; when the region exists the insert hitsON CONFLICT DO NOTHINGand Hasura refuses to insert the nested row ('cannot proceed to insert array relations ... affects zero rows'), the same error behind #411.insertRegionIfAbsentnow treats it as already present and answerscreated: false, which is what the endpoint documents.Tests: the region insert answers false on that error, true when a row is written, and still throws on any other error.
npx jest src/classes/graphql src/api src/utils: 22 suites, 281 tests passed.tsc --noEmitclean.🤖 Generated with Claude Code