Skip to content

ci: finalise pr coverage against the pr head commit - #935

Merged
milkshakeuk merged 1 commit into
masterfrom
ci/codacy-final-commit-uuid
Nov 17, 2026
Merged

milkshakeuk merged 1 commit into
masterfrom
ci/codacy-final-commit-uuid

Conversation

@milkshakeuk

Copy link
Copy Markdown
Member

The PR coverage workflow runs on workflow_run and never checks out the code, so the Codacy reporter can't work out the commit itself. report already passes --commit-uuid "$HEAD_SHA", but final didn't, so it fell back to GITHUB_SHA. On workflow_run that is the latest master commit, so the PR's partial coverage upload was being finalised against the wrong commit.

This passes the same PR head SHA to final. build-status.yml checks out the commit it tests, so it doesn't need the change.

@codacy-production

codacy-production Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (7e9b480) 1018621 22857 2.24%
Head commit (94cc1e7) 1018621 (+0) 22857 (+0) 2.24% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#935) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions

Copy link
Copy Markdown

Unit Test Results

    5 files      5 suites   11s ⏱️
1 431 tests 1 343 ✅  88 💤 0 ❌
2 692 runs  2 588 ✅ 104 💤 0 ❌

Results for commit 94cc1e7.

@sonarqubecloud

Copy link
Copy Markdown

@milkshakeuk
milkshakeuk merged commit 5b3865a into master Nov 17, 2026
14 checks passed
@milkshakeuk
milkshakeuk deleted the ci/codacy-final-commit-uuid branch November 17, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant