Skip to content

Stabilize WEBrick test fixture lifecycle - #489

Merged
yyuu merged 1 commit into
nahi:masterfrom
yyuu:ci/webrick-fixture-lifecycle
Nov 4, 2026
Merged

yyuu merged 1 commit into
nahi:masterfrom
yyuu:ci/webrick-fixture-lifecycle

Conversation

@yyuu

@yyuu yyuu commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Start WEBrick servers only when a test first needs them.
  • Join listener threads during teardown and continue cleanup if client teardown raises.
  • Add focused lifecycle tests and remove redundant server setup from unrelated tests.

The original intermittent failure was not reproduced. This PR isolates the fixture lifecycle changes for review.

Testing

  • Local suite: 262 tests, 886 assertions, no failures or errors (8 omissions), on Ruby 3.4.7.
  • GitHub Actions: all 12 Ruby/JRuby matrix jobs passed on the first attempt.

@yyuu
yyuu marked this pull request as ready for review November 4, 2026 06:17
@yyuu

yyuu commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

This only touches test code, and at least it is not contributing the stability worse so far. I'm planning to proceed for merging as it is.

@yyuu
yyuu merged commit ea332b7 into nahi:master Nov 4, 2026
47 of 48 checks passed
@yyuu
yyuu deleted the ci/webrick-fixture-lifecycle branch November 4, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant