Skip to content

feat(app): draw sidebars and the ribbon edge to edge - #190

Merged
Limdongcheng merged 1 commit into
mainfrom
feat/edge-to-edge-chrome
Nov 15, 2026
Merged

Limdongcheng merged 1 commit into
mainfrom
feat/edge-to-edge-chrome

Conversation

@Limdongcheng

Copy link
Copy Markdown
Collaborator

Summary

  • Sidebars meet the window edges instead of floating as rounded cards, with a 1 px divider toward the workspace.
  • The Ribbon meets the window edges on every platform and forms one surface with the Windows and Linux title bar, with a 1 px divider below.
  • Sidebar content keeps clear of the Windows and Linux resize zones: 8 pt from the side edges and 12 pt from the bottom.
  • Draw a 1 px window outline on Linux when the window is not maximized or full screen.
  • Raise control and surface corner radii to 8 and 12 pt on macOS and Linux; Windows keeps 4 and 8 pt. The Canvas/Data switcher follows the control radius.
  • Move viewport setup, surface fills, and the edge frame into window_shell so other windows can reuse them.

Validation

  • cargo pr-check on macOS; build, Clippy and tests on Linux.
  • Updated tests: sidebar resize grab and cursor with a draggable board behind the workspace margin, task-card bounds, platform corner radii.
  • New tests: edge chrome has no card geometry; dividers stay inside their surface at 1x, 1.5x and 2x.
  • Light and dark PLOTIUM_SHOT captures on Linux.

UI display logic

  • No layout changes from background events; panels are never auto-closed.

@Limdongcheng
Limdongcheng merged commit 6943e26 into main Nov 15, 2026
11 checks passed
@Limdongcheng
Limdongcheng deleted the feat/edge-to-edge-chrome branch November 15, 2026 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant