Repository navigation
lookup: migrate prom-client to @prometheus-io/client - #1217
Conversation
Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1217 +/- ##
=======================================
Coverage 96.09% 96.09%
=======================================
Files 29 29
Lines 2201 2201
=======================================
Hits 2115 2115
Misses 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Im also attaching the output of the npm show prom-client
prom-client@15.1.3 | Apache-2.0 | deps: 2 | versions: 84
Client for prometheus
https://github.com/siimon/prom-client
DEPRECATED ⚠️ - prom-client has been replaced by @prometheus-io/client
keywords: Prometheus, Metrics, Client
dist
.tarball: https://registry.npmjs.org/prom-client/-/prom-client-15.1.3.tgz
.shasum: 69fa8de93a88bc9783173db5f758dc1c69fa8fc2
.integrity: sha512-6ZiOBfCywsD4k1BN9IX0uZhF+tJkV8q8llP64G5Hajs4JOeVLPCwpPVcpXy3BwYiUGgyJzsJJQeOIv7+hDSq8g==
.unpackedSize: 126.4 kB
dependencies:
tdigest: ^0.1.1, @opentelemetry/api: ^1.4.0
maintainers:
- siimon <simon@nyberg.io>
- simenb <sbekkhus91@gmail.com>
- zbjornson <zbbjornson@gmail.com>
dist-tags:
latest: 15.1.3
next: 15.0.0-1
published over a year ago by simenb <sbekkhus91@gmail.com>and the npm show of the npm show @prometheus-io/client
@prometheus-io/client@0.16.1 | Apache-2.0 | deps: 2 | versions: 4
Client for prometheus
https://github.com/prometheus/client_js
keywords: Prometheus, Metrics, Client
dist
.tarball: https://registry.npmjs.org/@prometheus-io/client/-/client-0.16.1.tgz
.shasum: 5fcfbb74075e84810f9201264099143c2e23c80a
.integrity: sha512-XkFPsGFGoSs/UMg/vh0QLDpanl/tsrOV5PLHdpGe8Ho+ir/Llhytr15j6y8ZwLrpIGzK9gTVVpIalA6C4UjUZw==
.unpackedSize: 185.3 kB
dependencies:
@opentelemetry/api: ^1.4.0, tdigest: ^0.1.1
maintainers:
- prombot <prometheus-team@googlegroups.com>
- nexucis <husson.augustin@gmail.com>
- juliusv <julius.volz@promlabs.com>
dist-tags:
latest: 0.16.1
alpha: 0.16.0-alpha.1
published 2 months ago by GitHub Actions <npm-oidc-no-reply@github.com> |
|
If you click on the link in the original post The npm package prom-client is deprecated. you will also see the deprecated information.
Are you now part of the official citgm team from IBM / Red Hat? |
Yes, thank you for letting me know :) I just pasted the text from the npm show instead pasting the image
I work for IBM / Red Hat but Im not on the CITGM team |
|
I hope somebody from the official citgm team will review this and merge it. It's been open for more than 3 weeks. |
aduh95
left a comment
There was a problem hiding this comment.
Not part of CITGM, but LGTM anyway
To clarify, while we do have some platform interests within IBM / Red Hat, our contributions to CITGM are additional work that we volunteer time towards alongside our day-to-day responsibilities. We do this on a best-effort basis.
I appreciate your diligence in triaging test failures and keeping things moving. However, repeatedly chasing PRs and commenting on how long things take creates unnecessary pressure, which risks disincentivising both existing contributors and newcomers. The repository may not always operate at the pace you're expecting, given that only a handful of people are actively maintaining it. Until we have additional volunteers reviewing and merging PRs, more patience would be appreciated by those already giving their time. |
|
@aduh95 - Many thanks for merging! @BethGriggs - Thanks also to you for volunteering and the work you are doing in this repo. I understand that you have limited bandwidth, and my intention was never to pressure you or the team. The open PRs speak for themselves and I will not comment on them further unless there is a change in situation which needs highlighting. |

prom-clientdeprecated and moved to@prometheus-io/client#1216Situation
The npm package prom-client is deprecated. The repo https://github.com/siimon/prom-client redirects to https://github.com/prometheus/client_js .
The final version of
prom-clientwas 15.1.3, published in June 2024.cigtm prom-clientconfusingly reports it has testedprom-client@0.16.0although there is no such package available. It actually tests@prometheus-io/client@0.16.0.With the package migration, the maintainers have also changed and https://github.com/prometheus/client_js/blob/main/MAINTAINERS.md lists:
Change
prom-clientto@prometheus-io/clientChecklist
npm testpasseshere
cc: @jdmarshall @zbjornson