Skip to content

lookup: Unskip gulp on win32 and macos - #1241

Open
pacostas wants to merge 2 commits into
nodejs:mainfrom
pacostas:unskipping-gulp-macos-win32
Open

pacostas wants to merge 2 commits into
nodejs:mainfrom
pacostas:unskipping-gulp-macos-win32

Conversation

@pacostas

@pacostas pacostas commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Tests for gulp pass on macos (darwin/arm64, darwin/amd64) and windows (windows/arm64, window/amd64). I still unskip the windows/x86 as Nodejs has been deprecated on running these architectures and also I dont have a way to test it.

That way we increase the test coverage and also gulp does not have a new release over a year, which can give a good insight whether something has break on the Node.js side or not.

Related PR

The following PR also updates the maintainers of gulp, #1239

Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter

codecov-commenter commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.09%. Comparing base (7005bf1) to head (5edae35).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          29       29           
  Lines        2201     2201           
=======================================
  Hits         2115     2115           
  Misses         86       86           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pacostas

pacostas commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Does on the jenkins side, the windows/x86 is being tested?

@MikeMcC399

Copy link
Copy Markdown
Member

I still unskip the windows/x86_64 as Nodejs has been deprecated on running these architectures and also I dont have a way to test it.

Can you give a reference which says that Node.js is deprecated on windows/x86_64? Perhaps you meant a 32-bit architecture?

You've added win32-ia32 but I don't see any 32-bit systems being tested in Jenkins, so that is probably not necessary.

Does on the jenkins side, the windows/x86_64 is being tested?

Again it sounds like you mean 32-bit, however x86_64 refers to 64-bit and this is still active.

Comment thread lib/lookup.json Resolved
@pacostas

pacostas commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

I still unskip the windows/x86_64 as Nodejs has been deprecated on running these architectures and also I dont have a way to test it.

Can you give a reference which says that Node.js is deprecated on windows/x86_64? Perhaps you meant a 32-bit architecture?

Yes, I mean 32-bit, Im correcting it on the description too

@pacostas

pacostas commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Does on the jenkins side, the windows/x86_64 is being tested?

Again it sounds like you mean 32-bit, however x86_64 refers to 64-bit and this is still active.

Oops, I corrected the comment too, thank you!

Comment thread lib/lookup.json Resolved
Co-authored-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
@pacostas

Copy link
Copy Markdown
Contributor Author

Does on the jenkins side, the windows/x86 is being tested?

Based on @MikeMcC399 input, the answer is no.

@MikeMcC399 MikeMcC399 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gulp@5.0.1 tests successfully in GitHub Actions

image

@pacostas pacostas changed the title Unskip gulp on win32 and macos lookup: Unskip gulp on win32 and macos Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants