Skip to content

lookup: Unskip yeoman-generator - #1242

Open
pacostas wants to merge 1 commit into
nodejs:mainfrom
pacostas:unskiping-yeoman-genearator
Open

pacostas wants to merge 1 commit into
nodejs:mainfrom
pacostas:unskiping-yeoman-genearator

Conversation

@pacostas

@pacostas pacostas commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR unskips yeoman-generator for:

  • all Nodejs versions
  • all platforms e.g. amd, arm, etc.
  • all operating systems

Based on this PR #1035 yeoman-generator got skipped for Node.js version >=21. Since then almost 3 years have passed and yeoman has already 3 major bump versions.

I tested the module on macos (x64, arm64), ubuntu (x64,arm64) and windows 11 (arm64,x64) and all the tests pass.

I believe is a good addition for expanding the test coverage of Node.js as after the EOL of Node 20, this module stopped being used on the testing of Node.js due to the skip tag is >=21.

Checklist
  • npm test passes
  • contribution guidelines followed
    here

@codecov-commenter

codecov-commenter commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.09%. Comparing base (7005bf1) to head (22b6dde).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1242   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files          29       29           
  Lines        2201     2201           
=======================================
  Hits         2115     2115           
  Misses         86       86           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants