Repository navigation
Fix undefined sorting params in playlists table - #1689
Merged
Merged
Conversation
There was a bug where missing values for sort parameters of new tables where overriding the new default values. This fix is to change merging order, i.e. to make this work the other way around. This will only affect missing values, so actual stored values will still take precedence over the defaults.
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/1689/2026-10-15_08-13-21/ . |
Arnei
requested changes
Oct 14, 2026
Arnei
left a comment
Arnei
left a comment
Member
There was a problem hiding this comment.
Looks good and works. The stuff below is less "request changes" and more "comprehension questions".
Member
|
This should probably go into |
owi92
force-pushed
the
fix-playlists-sort
branch
from
October 15, 2026 08:12
ae5ad54 to
5faf60b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug where missing values for sort parameters of new tables were overriding the new default values.
This fix is to change merging order, i.e. to make this work the other way around. This will only affect missing values, so actual stored values will still take precedence over the defaults.
Fixes #1688