Repository navigation
Align this.<prop> rewriting with wabac.js's cleaner implementation - #404
Merged
Merged
Conversation
We proposed webrecorder/wabac.js#395 for the newline/dot detection bug in replace_this_prop, but wabac.js landed webrecorder/wabac.js#398 instead, a cleaner fix for the same bug with slightly different edge case behavior: a leading `this.<prop>` at the very start of a script is now rewritten too, and a preceding `$` only blocks the rewrite when directly adjacent (a `.` still blocks it regardless of the amount of whitespace in between).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 2952 2954 +2
Branches 452 453 +1
=========================================
+ Hits 2952 2954 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We proposed webrecorder/wabac.js#395 for the newline/dot detection bug in
replaceThisProp(backported toreplace_this_prophere in #381), but wabac.js landed webrecorder/wabac.js#398 instead: a cleaner fix for the same bug, with slightly different edge-case behavior. This aligns our implementation with it:this.<prop>at the very start of a script is now rewritten too (previously treated the start of the script like a blocking./$prefix).$now only blocks the rewrite when directly adjacent tothis(no whitespace in between); a preceding.still blocks it regardless of the amount of whitespace in between.