Repository navigation
Pin Mago to 1.59.0 in CI - #8
Merged
Merged
Conversation
setup-php installed whatever Mago release was latest, so a new release could fail every consumer's CI with no change on their side. 1.59.0 did exactly that to php-db/phpdb's 0.6.x. The mago and mutation-test jobs now install the release named by a new mago-version input, defaulting to 1.59.0. mago.toml pins the same version, so a local binary that differs is flagged with a warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
magoandmutation-testjobs install Mago withtools: mago, so setup-php fetches whatever release is latest. When Mago 1.59.0 shipped, php-db/phpdb's0.6.xstarted failing CI with no code change: 1.59 reformats one file and reports findings that the committed baseline no longer matches. Every open PR that updates against0.6.xinherits the failure, and the mutation-test job fails too because Infection runsmago analyzefirst.Fix
mago-versionworkflow input, defaulting to"1.59.0". Both jobs now installmago:${{ inputs.mago-version }}(setup-php supports a release tag for Mago).mago.tomlpinsversion = "1.59.0"instead of"1". A local binary with a different version only gets a warning, so local runs don't break.docs/workflow-architecture.mddocuments the input.Moving to a newer Mago becomes a deliberate change: bump the default here and in
mago.toml, then fix any new findings in each consumer.The workflow pin applies to every repo calling
@0.1.xonce this merges. Themago.tomlpin reaches a repo when it next updatesphp-db/phpdb-qa-tools.Companion fix for php-db/phpdb: php-db/phpdb#245