Repository navigation
chore: promote dev to master - #87
Merged
Merged
Conversation
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.14.0 to 3.14.2. - [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md) - [Commits](nodeca/js-yaml@3.14.0...3.14.2) --- updated-dependencies: - dependency-name: js-yaml dependency-version: 3.14.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash dependency-version: 4.17.23 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
The 355/113 approximation of pi put trig results off by about 1e-7, which the symbolic comparison hid by rounding to 4 decimals.
Constant results were rounded to 4 decimals, so any number within 0.00005 of the answer was scored correct. Compare constants with a 1e-12 relative tolerance instead, which only absorbs floating-point noise from trig functions and pi.
Re-enable the commented-out ne assertions in math-evaluator.
…eric checks (PIE-443) areNumericallyEquivalent gave every variable the same integer values, so it could not tell x^2 from y^2. Use fixed-seed pseudo-random values, different for each variable, and add a check for equations that are constant (or variable-factor) multiples of each other.
…valent (PIE-443) Two-variable equations were compared by solving for y at x = 1. For equations that are not linear in y both solutions were undefined, and undefined === undefined scored any such pair as equivalent. Compare equations in two variables numerically instead, guard the inequality path against undefined solutions, and fall back to the numeric check for one-variable equations that are neither linear nor quadratic.
…PIE-443) Targets are the correct answers of items E217532, E232686, E234938 and E234162; ne cases are the changes reported in the ticket.
normalize() replaced any constant result >= 1,497,258 (or <= -1,497,258) with Infinity, so 2000000 and 3000000 were scored as equal. The cutoff was tan(90°) under the 355/113 approximation of pi. Undefined trigonometric values are now detected directly: before normalizing, tan/sec at odd multiples of pi/2 and cot/csc at multiples of pi become Infinity, and sin/cos at their zeros become an exact 0. A constant expression containing an undefined value is evaluated numerically, since simplify treats Infinity as a variable. The size cutoff is removed, so large numbers are compared by value.
…yaml-3.14.2 Bump js-yaml from 3.14.0 to 3.14.2
…ash-4.17.23 Bump lodash from 4.17.21 to 4.17.23
… at x = 1 (PIE-1419)
…c comparisons (PIE-905)
…zero no sign (PIE-1418) Tighten the angle tolerance to 2e-7 quarter turns relative to k, so angles that are only close (89.9999°, 1.5708) are no longer undefined. Snap tan and cot to 0 at their zeros, evaluate every constant expression with a snapped value so -1/cos(90°) is unsigned Infinity, and keep indeterminate results such as tan(90°)-tan(90°) as NaN instead of 0.
…ic equation checks (PIE-443)
…egative values (PIE-1419)
…ariable (PIE-1419)
…s next to replaced zeros (PIE-1418)
… expressions (PIE-443)
fix(symbolic): stop accepting near-miss numbers (PIE-905)
Keeps both sides of the conflict in src/symbolic/index.ts: the numeric comparison helpers from PIE-905 and isIndeterminate from PIE-1418. Degrees now convert with Math.PI, so angles are matched against Math.PI only.
fix(symbolic): compare two-variable inequalities by region instead of at x = 1 (PIE-1419)
fix(symbolic): stop treating large numbers as infinity (PIE-1418)
|
🎉 This PR is included in version 1.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.