Skip to content

dev2: every site's secrets from its logicsrc vault - #243

Merged
ralyodio merged 1 commit into
masterfrom
fleet-vaults
Nov 8, 2026
Merged

ralyodio merged 1 commit into
masterfrom
fleet-vaults

Conversation

@ralyodio

@ralyodio ralyodio commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Applied on dev2 2026-11-08 and verified: 91 sites pull app.env from logicsrc on deploy; a fleet-wide simulation of the next deploy changes no live value; real deploys of nichedb.dev (bespoke script), bl0ggers.com (template) and openaccess.logicsrc.com (image-only) were healthy with quote-only app.env rewrites.

This PR records it so re-provisioning keeps it: normalized default vault names, new vault_skip, and per-site vault/vault_skip in sites.d (values never stored here, names only).

🤖 Generated with Claude Code

All dev2 sites now pull app.env from a logicsrc team vault on each deploy
(VAULT in deploy.env, sync_env_from_vault). Vaults were synced from the live
app.env first; 2026-11-08.

- dev2-site: default vault names are normalized (c0ncerts.com ->
  c0ncerts-com--prod; a dotted name is refused and the deploy pulled nothing)
- dev2-site: new vault_skip (kept in app.env, never taken from the vault):
  signing keys logicsrc refuses, values that do not round-trip, vault-only
  keys. env_remove still also skips.
- sites.d: record each non-default vault (incl. separate vaults for sites
  that shared one: app.logicsrc.com, installer.pairux.com, bbs.hqtui.com)
  and each site's vault_skip.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

ThreatCrush Security Scan

41 finding(s)

HIGH/CRITICAL: 15 | MEDIUM: 12 | LOW: 14

Severity Rule Location
HIGH py-ssrf-outbound-request dev2/dev2-site:151
HIGH py-ssrf-outbound-request dev2/dev2-site:1099
HIGH py-ssrf-outbound-request dev2/dev2-site:1903
HIGH sh-remote-script-execution root-ubuntu.sh:3262
HIGH sh-remote-script-execution root-ubuntu.sh:3263
HIGH sh-remote-script-execution root-ubuntu.sh:5168
HIGH sh-remote-script-execution root-ubuntu.sh:5172
HIGH sh-remote-script-execution root-w3bs-os.sh:3639
HIGH sh-remote-script-execution root-w3bs-os.sh:3640
HIGH sh-remote-script-execution root-w3bs-os.sh:5569
HIGH sh-remote-script-execution root-w3bs-os.sh:5579
HIGH sh-remote-script-execution root-w3bs-os.sh:5586
HIGH sh-remote-script-execution root-w3bs-os.sh:5602
HIGH sh-remote-script-execution root-w3bs-os.sh:5607
HIGH sh-plaintext-download root-w3bs-os.sh:6289
MEDIUM sql-template-interpolation dev2/dev2-site:1334
MEDIUM sql-template-interpolation dev2/dev2-site:1411
MEDIUM sh-remote-script-execution root-ubuntu.sh:5376
MEDIUM redos-nested-quantifier src/domain-free.ts:56
MEDIUM redos-nested-quantifier src/emoji.ts:167
MEDIUM redos-nested-quantifier src/icon.ts:166
MEDIUM redos-nested-quantifier src/mail.ts:1060
MEDIUM sql-template-interpolation src/users-dump.ts:487
MEDIUM sql-string-concatenation src/users-dump.ts:507
MEDIUM sql-template-interpolation src/users-dump.ts:540
MEDIUM sql-string-concatenation src/users-dump.ts:574
MEDIUM redos-nested-quantifier src/wcag.ts:556
LOW secret-generic-credential src/credentials.ts:41
LOW secret-generic-credential src/credentials.ts:58
LOW secret-generic-credential src/credentials.ts:61
LOW secret-generic-credential src/credentials.ts:66
LOW secret-generic-credential src/user-export.ts:689
LOW secret-generic-credential src/user-export.ts:695
LOW secret-generic-api-key test/credentials.test.ts:208
LOW secret-generic-credential test/mail.test.ts:141
LOW secret-generic-credential test/proxy.test.ts:69
LOW secret-generic-credential test/proxy.test.ts:85
LOW secret-generic-credential test/shorten.test.ts:36
LOW secret-database-url test/users-dump.test.ts:108
LOW secret-database-url test/users-dump.test.ts:119
LOW secret-database-url test/users-dump.test.ts:120

Snippets are redacted; ThreatCrush never prints matched credential material.

@ralyodio
ralyodio merged commit 366cf70 into master Nov 8, 2026
5 checks passed
@ralyodio
ralyodio deleted the fleet-vaults branch November 8, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant