Skip to content

fix(cli): run flows on Chrome 157 with puppeteer 25.17 - #351

Merged
ChristopherPHolder merged 2 commits into
mainfrom
fix/puppeteer-25-chrome-157
Nov 13, 2026
Merged

ChristopherPHolder merged 2 commits into
mainfrom
fix/puppeteer-25-chrome-157

Conversation

@ChristopherPHolder

@ChristopherPHolder ChristopherPHolder commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #349

What changed

  • Puppeteer ^25.16.0 → ^25.17.0 in the root and @push-based/user-flow manifests. chore: update dependencies to latest #294 already moved main to v25. This raises the floor to 25.17.0, the release that ships Chrome 157.0.8103.50, so installs can't resolve to an older Chrome. The published 0.21.5 still depends on ^24.24.0 (Chrome 148), so this release is the first one that runs flows on Chrome 157.
  • headless: 'new' → headless: true in parseLaunchOptions (CI and sandbox mode). Puppeteer v22+ types headless as boolean | 'shell', and true is the new headless mode, so the cast is gone. parseLaunchOptions is now exported and has unit tests covering DEFAULT, CI and SANDBOX.

Breaking changes in the v25 launch options

user-flow passes launchOptions from the user-flow file straight to puppeteer.launch. Apart from headless, it sets only defaultViewport itself, and that option didn't change in v25. @puppeteer/replay@4.0.2 takes puppeteer >=23 as a peer dependency, so v25 is in range.

Verification

  • cli unit tests (78), lint and build pass.
  • cli-e2e passes on Chrome 157 (23 tests).
  • Manual replay: the order-coffee-1 recording run through user-flow collect with CI=1 launches headless on Chrome/157 and replays every step. The timespan step reports Performance 0.99 with no audit errors.

Raise the puppeteer floor to ^25.17.0, which ships Chrome 157.0.8103.50.
The 24.x line stops at Chrome 148, where soft navigations get no
Performance score (NO_TTI_CPU_IDLE_PERIOD).

In CI and sandbox mode, launch with headless: true instead of casting
the removed 'new' value onto the launch options.

Closes #349
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

The fallback launch options gave every run a mobile defaultViewport,
although it was only meant for --dry-run. A replayed DevTools recording
starts with setViewport and isMobile: false, which makes Puppeteer
reload the page inside the timespan. Lighthouse then logs a TypeError
for the resulting about:blank navigation.

Real runs now use Puppeteer's default viewport. Dry runs are unchanged.

Closes #352
@github-actions

Copy link
Copy Markdown

❗❗❗ report generated by this PR ❗❗❗

☕ Order Coffee ☕

Date/Time: 2026-11-13 09:23

Step Name Gather Mode Performance Accessibility Best Practices Seo Agentic Browsing
🧭 Navigate to coffee cart navigation 86 93 100 83 50
☕ Select coffee timespan 17/17 - 8/8 - -
✔ Coffee selected snapshot Ø 1/1 16/18 4/4 3/5 1/3
🛒 Checkout order timespan 19/19 - 8/8 - -
🧾 Order checked out snapshot Ø 1/1 19/20 4/4 3/5 1/3
💌 Submit order timespan 18/18 - 8/8 - -
📧 Order submitted snapshot Ø 1/1 20/22 4/4 3/5 1/3
🧭 Navigate to github navigation 98 92 100 83 50

@github-actions

Copy link
Copy Markdown

☕ Order Coffee ☕

Date/Time: 2026-11-13 09:24

Step Name Gather Mode Performance Accessibility Best Practices Seo Agentic Browsing
🧭 Navigate to coffee cart navigation 93 93 100 83 50
☕ Select coffee timespan 17/17 - 8/8 - -
✔ Coffee selected snapshot Ø 1/1 16/18 4/4 3/5 1/3
🛒 Checkout order timespan 19/19 - 8/8 - -
🧾 Order checked out snapshot Ø 1/1 19/20 4/4 3/5 1/3
💌 Submit order timespan 18/18 - 8/8 - -
📧 Order submitted snapshot Ø 1/1 20/22 4/4 3/5 1/3
🧭 Navigate to github navigation 89 92 100 83 50

@ChristopherPHolder
ChristopherPHolder merged commit ee32b9e into main Nov 13, 2026
5 checks passed
@ChristopherPHolder
ChristopherPHolder deleted the fix/puppeteer-25-chrome-157 branch November 13, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Puppeteer to v25: v24 runs flows on Chrome 148

1 participant