Repository navigation
fix(cli): run flows on Chrome 157 with puppeteer 25.17 - #351
Merged
Merged
Conversation
Raise the puppeteer floor to ^25.17.0, which ships Chrome 157.0.8103.50. The 24.x line stops at Chrome 148, where soft navigations get no Performance score (NO_TTI_CPU_IDLE_PERIOD). In CI and sandbox mode, launch with headless: true instead of casting the removed 'new' value onto the launch options. Closes #349
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The fallback launch options gave every run a mobile defaultViewport, although it was only meant for --dry-run. A replayed DevTools recording starts with setViewport and isMobile: false, which makes Puppeteer reload the page inside the timespan. Lighthouse then logs a TypeError for the resulting about:blank navigation. Real runs now use Puppeteer's default viewport. Dry runs are unchanged. Closes #352
❗❗❗ report generated by this PR ❗❗❗☕ Order Coffee ☕Date/Time: 2026-11-13 09:23
|
☕ Order Coffee ☕Date/Time: 2026-11-13 09:24
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #349
What changed
^25.16.0→^25.17.0in the root and@push-based/user-flowmanifests. chore: update dependencies to latest #294 already moved main to v25. This raises the floor to 25.17.0, the release that ships Chrome 157.0.8103.50, so installs can't resolve to an older Chrome. The published 0.21.5 still depends on^24.24.0(Chrome 148), so this release is the first one that runs flows on Chrome 157.headless: 'new'→headless: trueinparseLaunchOptions(CI and sandbox mode). Puppeteer v22+ typesheadlessasboolean | 'shell', andtrueis the new headless mode, so the cast is gone.parseLaunchOptionsis now exported and has unit tests covering DEFAULT, CI and SANDBOX.Breaking changes in the v25 launch options
user-flowpasseslaunchOptionsfrom the user-flow file straight topuppeteer.launch. Apart fromheadless, it sets onlydefaultViewportitself, and that option didn't change in v25.@puppeteer/replay@4.0.2takespuppeteer >=23as a peer dependency, so v25 is in range.Verification
cliunit tests (78), lint and build pass.cli-e2epasses on Chrome 157 (23 tests).order-coffee-1recording run throughuser-flow collectwithCI=1launches headless on Chrome/157 and replays every step. The timespan step reports Performance 0.99 with no audit errors.