Repository navigation
Include solar and wind battery systems in the energy flow sankey. - #3529
Merged
Merged
Conversation
kndehaan
reviewed
Nov 17, 2026
Comment on lines
+21
to
+26
| V( | ||
| energy_flexibility_curtailment_electricity, | ||
| energy_battery_curtailed_solar_electricity, | ||
| energy_battery_curtailed_wind_electricity, | ||
| demand | ||
| ) |
Member
There was a problem hiding this comment.
Could you create a new query in which the demand of these three nodes are queried? That would look more neat it here.
Member
|
Looking good! Only one cosmetic comment that you could process. Once done, we can merge this! |
kndehaan
approved these changes
Nov 20, 2026
kndehaan
left a comment
Member
There was a problem hiding this comment.
Good work! I did some very minor changes which are rather a personal preference:
- I omitted some excessive explanation here and there. It's good to add descriptions in the doc strings, but some information is in my opinion too excessive to mention
- Swapped the line
V(energy_power_hv_network_loss, demand)to be below the new query line. I like to have all the queries first and finally the individual querying on node bases.
The output nodes of the solar PV and inland wind parks with batteries have no solar radiation or wind input, so they were filtered out of the overview sankey. Use the existing producer groups that add these nodes explicitly. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kndehaan
force-pushed
the
solar-wind-battery
branch
from
November 20, 2026 14:54
388e93b to
18d38fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
People often use the energy sankey (Energy flow overview) to get a feeling for what their energy system looks like.
Electricity produced from a nonzero slider wind onshore (with battery system) or solar PV on land (with battery system) do not show up in the energy sankey. Additionally, battery losses and curtailment are not correctly incorporated in the energy sankey.
Implemented changes
conversion_from_solar/wind_to_electricity.energy_flexibility_solar/wind_batteries_electricity_losses.conversion_loss_electricty_to_electricityto include all curtailed electricity.Related
Closes issue 4833
Checklist