Repository navigation
docs: fix 404 broken relative links in direct-manipulation.md - #5311
Closed
supunyasanthaofficial wants to merge 1 commit into
Closed
supunyasanthaofficial wants to merge 1 commit into
supunyasanthaofficial wants to merge 1 commit into
Conversation
Collaborator
|
Hey @supunyasanthaofficial, those links works on PROD and when running app locally, so there is no need to change them: |
Contributor
Author
|
Thanks for clarifying, @Simek I noticed the 404 while navigating the files directly on GitHub's preview and assumed it broke the rendered site as well. Since Docusaurus resolves the doc ID correctly on production and local dev, I'll go ahead and close this PR. |
Collaborator
|
Yeah, unfortunately a lot of links would be broken when navigating on the GitHub, since Docusaurus modifies the links path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed broken links in
docs/legacy/direct-manipulation.mdthat were leading to 404 pages.The issue was caused by incorrect relative paths. Since the file is inside the
legacy/directory, links pointing toview.mdwere resolving to/docs/legacy/view.mdinstead of the actual View component documentation.Updated both links to use
../view.md, fixing the references toonMoveShouldSetResponderandonLayout.Applied the same fix across all versioned documentation, from
version-0.77toversion-0.88.Test Plan
yarn buildto check the documentation build.