Repository navigation
Profiling: check that a trace contains frames before reading it - #5312
Ky0-Nguyen wants to merge 1 commit into
Conversation
|
Hi @Ky0-Nguyen! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Adds a short step to the Android system tracing guide in
docs/profiling.md: check that a trace actually contains frames before reading it.A capture with no frame data is easy to read as a smooth app, because an empty track looks the same as a fast one. The new step:
Choreographer#doFrame/DrawFrameslices, and on Android 12+ the Expected/Actual Timeline tracks;The following steps are renumbered (Reading the trace is now 3, Find your process is 4). Nothing else on the page links to those anchors.
Context: react-native-community/discussions-and-proposals#1025. Thanks to @SanketPathare for suggesting that the docs define what counts as a frame and which threshold applies.