Skip to content

Profiling: check that a trace contains frames before reading it - #5312

Open
Ky0-Nguyen wants to merge 1 commit into
react:mainfrom
Ky0-Nguyen:docs/profiling-check-trace-has-frames
Open

Ky0-Nguyen wants to merge 1 commit into
react:mainfrom
Ky0-Nguyen:docs/profiling-check-trace-has-frames

Conversation

@Ky0-Nguyen

Copy link
Copy Markdown

Adds a short step to the Android system tracing guide in docs/profiling.md: check that a trace actually contains frames before reading it.

A capture with no frame data is easy to read as a smooth app, because an empty track looks the same as a fast one. The new step:

  • lists what to check for the recorded interaction: the app's process, Choreographer#doFrame / DrawFrame slices, and on Android 12+ the Expected/Actual Timeline tracks;
  • gives the common reasons a trace has no frames (not run as profileable, recording missed the interaction, device doesn't report the tracks);
  • states the frame budget by refresh rate (16.7ms at 60Hz, 11.1ms at 90Hz, 8.3ms at 120Hz) rather than a fixed 16ms.

The following steps are renumbered (Reading the trace is now 3, Find your process is 4). Nothing else on the page links to those anchors.

Context: react-native-community/discussions-and-proposals#1025. Thanks to @SanketPathare for suggesting that the docs define what counts as a frame and which threshold applies.

@meta-cla

meta-cla Bot commented Nov 3, 2026

Copy link
Copy Markdown

Hi @Ky0-Nguyen!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant