Repository navigation
Conversation
Signed-off-by: piguagua <shabipengqi@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EthToWeiWithDecimals constructs 10^decimals as a float64 before multiplying. For decimals such as 24 and 36, the scale is already rounded and even an amount of 1 produces the wrong integer. Parse the existing decimal representation as a rational, multiply by an exact integer power of ten, and divide with truncation toward zero.
The table covers high decimal counts, fractional amounts, negative values and truncation.
go test ./shared/math -count=1passed. The input remains float64; this patch does not recover precision already lost by callers.