Skip to content

test: add health, last_verified_at, credentials_expire_at and account_label to the connection fixture - #106

Merged
MingHill-Roe merged 1 commit into
mainfrom
ming/connection-fixture-health
Nov 17, 2026
Merged

MingHill-Roe merged 1 commit into
mainfrom
ming/connection-fixture-health

Conversation

@MingHill-Roe

Copy link
Copy Markdown
Contributor

Summary

Release 1-1-6 adds four read-only fields to the Connection schema: health, last_verified_at, credentials_expire_at and account_label. Read-only fields are marked required in the OpenAPI spec, so the regenerated Connection.from_dict reads each one with no default.

The hand-written _connection_json() fixture in tests/unit/test_connections_wrapper_transport.py had none of them, so three wrapper transport tests fail with KeyError: 'health' on the release PR (#104):

  • test_connection_create_keeps_org_id_in_body_and_query
  • test_connection_update_keeps_org_id_out_of_patch_body
  • test_connection_replace_keeps_org_id_out_of_put_body

This PR adds the four keys to the fixture. It is a test-only change to one file.

It targets main rather than the release branch because the release workflow rebuilds release-sdk-python-* from main on every run. The extra keys are harmless on the current generated model, so this can merge ahead of the release PR. Same kind of fix as #84.

Test Plan

  • uv run pytest on this branch (current main model): 68 passed
  • uv run pytest on release-sdk-python-1-1-6 (2bee7a5) with this fixture dropped in: 68 passed, including the three tests that fail in CI on Release v1.1.24 #104
  • ruff check and ruff format --check on the changed file: clean

Self-review: one file, four added lines, no findings.

After merge

Re-run the Python update-sdk job in the roe-main release workflow for release-1-1-6 so #104 is rebuilt from main and its test job goes green.

🤖 Generated with Claude Code

@MingHill-Roe
MingHill-Roe merged commit b46dad8 into main Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants