Repository navigation
Allow allowlist and blocklist in browser options hash - #330
Greg-Myers-SB wants to merge 1 commit into
Conversation
The alias for these already existed within this file but the options hash did not until now.
|
The test failures on 3.1 look the same as these test failures on another branch. |
|
Thanks for the PR! The idea is good, but as it stands the new keys only work until the first Capybara reset.
# lib/capybara/cuprite/driver.rb
browser.url_blacklist = @options[:url_blacklist]
browser.url_whitelist = @options[:url_whitelist]So when the driver is registered with To land this, it would need:
I'm closing this for now. Feel free to reopen or open a new PR with those changes. The 3.1 failure is an unrelated flaky spec, as you noted. |
|
Hi @route , thank you for the feedback, I have two PRs. #361 addresses your feedback to allow it to survive reset by pushing the change upwards into driver.rb, and Greg-Myers-SB#1 reverses some of the internals so blocklist/allowlist is the preferred terms instead of mapping onto old terms. I hope these satisfy 🙇 |
|
Looking good, thx! |
The alias for these already exist within this file but the options hash did not allow the aliased keys, until now.
Same as 575ef9c extended to options.