Repository navigation
fix(network): derive navigation_request? from the resource type of Fetch events - #699
Merged
Merged
Conversation
…tch events isNavigationRequest belonged to the deprecated Network.requestIntercepted event. Fetch.requestPaused and Fetch.authRequired don't send it, so both predicates returned nil since the switch to Fetch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InterceptedRequest#navigation_request?andAuthRequest#navigation_request?always returnednil. They readisNavigationRequest, a field of the deprecatedNetwork.requestInterceptedevent. Since the switch toFetch.requestPausedandFetch.authRequired(61f5a1c), which don't send it, the key was never present.Both now return
truewhenresource_typeis"Document".Note this is also true for subframe document requests.