Repository navigation
Conversation
…procs in page.on page.on(:request, &:continue) called continue(index, total), which raised and was dropped, so the request stayed paused. Callbacks for :request, :response, :auth and :dialog that can't take the extra index and total now get only the object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
page.on(:request, &:continue)never continued the request.onyields(object, index, total), so the symbol proc calledrequest.continue(index, total), which raisedArgumentError. The subscriber reported it as a warning and the request stayed paused.For
:request,:response,:authand:dialog, a lambda taking one argument and a symbol proc now get only the object. Regular blocks still get(object, index, total).