Repository navigation
fix(release): make ARM builds work with the DinD runner - #407
Merged
Merged
Conversation
Signed-off-by: overtrue <anzhengchao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both ARM64 release jobs exit with
cargo: not found: the DinD daemon cannot bind-mount the Rust toolchain installed in the runner's filesystem. This blocks v0.1.37 after the runner migration in #382.Set
CROSS_REMOTE=truefor cross builds so the toolchain and source are copied through Docker volumes. Build artifacts are copied back for packaging. This follows cross's remote-engine setup. The release still builds the requested tag.Validation: formatting, Clippy with warnings denied, all 1,988 workspace tests with RUST_LOG unset, and actionlint passed. The two failed ARM jobs are the regression evidence; the release retry will verify the runner fix.