Repository navigation
feat(bucket): manage public access block configuration - #410
Open
jmeiracorbal wants to merge 1 commit into
Open
jmeiracorbal wants to merge 1 commit into
jmeiracorbal wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
N/A. This adds the CLI operation needed by the RustFS bootstrap integration discussed in rustfs/rustfs#997.
Context
Bootstrap workflows need a way to keep bucket-level public access blocked by default. The CLI did not expose the S3 Public Access Block operations.
Solution
Add
rc bucket public-access-block get|set|removewith strict validation of all four flags, S3 API support, and an unsupported-by-defaultObjectStoreimplementation for compatibility with other backends.Validation
cargo fmt --all --check— passed.cargo clippy --workspace --all-targets -- -D warnings— passed.cargo test --workspace— passed (2,000 passed, 2 ignored).Impact
Adds bucket Public Access Block management to
rc; existingObjectStoreimplementations remain source-compatible.