Repository navigation
feat(vscode): make manual-publish's vsce leg a no-op for OIDC caller dispatch - W-24756661 - #212
Merged
Conversation
…dispatch - W-24756661 vscode-manual-publish.yml's publish job published vsce via a PAT through a job defined in this reusable workflow, whose job_workflow_ref can never match the caller's own workflow filename -- the same OIDC trust mismatch already solved for ovsx. apex-language-support is this workflow's only caller, so there's no other consumer relying on PAT-based vsce publish through this path; make the vsce leg an unconditional no-op mirroring the existing ovsx leg, and dispatch an OIDC-trusted publish workflow from the caller instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Author
|
Companion PR (ready to merge together): forcedotcom/apex-language-support#834 |
madhur310
marked this pull request as ready for review
November 13, 2026 23:09
peternhale
approved these changes
Nov 16, 2026
peternhale
added a commit
to forcedotcom/apex-language-support
that referenced
this pull request
Nov 16, 2026
…manual-publish - W-24756661 (#834) * feat(ci): publish VS Code Marketplace via OIDC trusted publishing in manual-publish - W-24756661 publishVSCodeMarketplaceTrusted.yml was a dispatch-only test-registration workflow for the Marketplace's OIDC trust check. With salesforcecli/github-workflows#207 merged (the publish-release-vsix OIDC composite action) and the vscode-manual-publish.yml change in salesforcecli/github-workflows#212, promote it to the real publish target: call the composite action directly instead of the old PR-branch reusable workflow reference, and wire manual-publish.yml to dispatch it on the version-tag path, mirroring trigger-openvsx-publish. Depends on salesforcecli/github-workflows#212 merging first -- that PR makes vscode-manual-publish.yml's vsce leg a no-op, since this workflow now handles the actual Marketplace publish. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * build: address sast scan false positive --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: peternhale <peternhale@users.noreply.github.com> Co-authored-by: peternhale <peter.hale@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
vscode-manual-publish.yml'spublishjob published to the VS Code Marketplace via a PAT, through a job defined in this reusable workflow. The Marketplace's OIDC trust check keys offjob_workflow_ref, which for a job in a reusable workflow always points here, never at the caller's own workflow filename — the same OIDC mismatch already fixed forsalesforcedx-vscodein #207/#8624.This mirrors the existing
ovsxno-op leg: thevsceleg is now an unconditional no-op too, so the caller dispatches its own OIDC-trusted publish workflow afterward instead (same pattern as the existingpublishOpenVSXTrusted.ymldispatch).apex-language-supportis this workflow's only caller (verified via code search — no other consumer), so there's no other caller relying on PAT-based vsce publish through this path, and the extra opt-in input originally considered was dropped as unnecessary.Verified
The companion PR's dispatch workflow (
publishVSCodeMarketplaceTrusted.yml, using the samepublish-release-vsixcomposite action this PR's callers rely on) was run end-to-end against the real VS Code Marketplace using OIDC:Run 43523373003 — success (against already-released
apex-language-server-extension-v0.10.0,dry-run=false,--skip-duplicatesafe no-op — no actual publish side effect)Merging this alone would silently stop the VS Code Marketplace publish in
apex-language-support's manual-publish pipeline (the job would report success while doing nothing). This must merge together with (or after) the companion PR inforcedotcom/apex-language-supportthat adds the OIDC dispatch workflow and wires it in.Companion PR: forcedotcom/apex-language-support#834