Repository navigation
Add Vale pre-commit hook - #758
Merged
sds merged 8 commits intoNov 10, 2026
Merged
Conversation
guillaume-d
marked this pull request as draft
June 18, 2021 07:36
guillaume-d
force-pushed
the
guillaume-d/bug/750-add-Vale-pre-commit-hook
branch
from
October 11, 2021 18:45
7565ef2 to
c9b308a
Compare
Contributor
Author
Rebased to adapt to latest configuration format changes. |
sds
marked this pull request as ready for review
November 10, 2026 07:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an opt-in Vale pre-commit hook that checks spelling and style in staged text, markup, and source files using the configurable line-aware command hooks merged in #757.
Implements the requirements described in this PR and its prerequisites:
PreCommit: { Vale: { enabled: true } }; no Ruby plugin is needed. The default command isvale --output=line, with executable detection, installation guidance, and configurable file selection.include,exclude,requires_files, andproblem_on_unmodified_line.YamlSyntax, while continuing to reject arbitrary Ruby objects.Validation: all 1,866 local examples pass, including 20 Vale-specific examples, a real subprocess with staged files, and YAML regression coverage. All repository pre-commit checks and RuboCop pass. A smoke test using the checksum-verified Vale 3.26.0 release confirms both failing diagnostics and a clean-file pass with a staged filename containing spaces. GitHub CI tests Ruby 3.3, 3.4, and 4.0 on Ubuntu and Windows.