Repository navigation
Honor Git cleanup rules for comment-prefixed commit messages - #929
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit-message hooks always removed comment-prefixed lines, causing
git commit -m '#16: ...'to failEmptyMessageeven when Git would preserve the title. Honor Git's effective cleanup mode when filtering comments, so hooks see those titles while messages that become empty under stripping cleanup are still rejected.Closes #736.
Resolve command-line
--cleanupoverrides beforecommit.cleanup, and use Git's documentedGIT_EDITOR=:marker for the editor-dependent default. Cache that result within the commit-message context. On Windows, follow theenv.exelauncher to the invoking Git process in the COM, Script Host, and PowerShell query paths, so command-line overrides are visible. Alternate comment characters and existing verbose-diff filtering continue to work.Adds unit and installed-hook integration tests for the scenarios in #736: default
-m, alternate comment characters, configured and explicit whitespace cleanup, quoted Windows options, overrides before/after the message, verbatim cleanup, editor-based commits, and empty-message rejection. Integration tests check the final message stored by Git.Validation: all 1,844 local RSpec examples pass; pre-commit checks and RuboCop pass. GitHub CI will verify Ruby 3.3/3.4/4.0 on Ubuntu and Windows.
References: Git commit cleanup modes, Git hook editor marker.